From: Sean Christopherson <seanjc@google.com>
To: Bibo Mao <maobibo@loongson.cn>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH] KVM: selftests: use unified time type for comparison
Date: Wed, 2 Aug 2023 12:30:43 -0700 [thread overview]
Message-ID: <ZMqu43iUfA/LsxlD@google.com> (raw)
In-Reply-To: <20230731022405.854884-1-maobibo@loongson.cn>
+Oliver to get input on something beyond non-x86, and because I hate anything
clock related :-)
On Mon, Jul 31, 2023, Bibo Mao wrote:
> With test case kvm_page_table_test, start time is acquired with
> time type CLOCK_MONOTONIC_RAW, however end time in function timespec_elapsed
> is acquired with time type CLOCK_MONOTONIC. This will cause
> inaccurate elapsed time calculation on some platform such as LoongArch.
>
> This patch modified test case kvm_page_table_test, and uses unified
> time type CLOCK_MONOTONIC for start time.
AFAICT, there's zero reason to use CLOCK_MONOTONIC_RAW instead of CLOCK_MONOTONIC.
If there are no objections, I'll take this through kvm-x86/selftests for 6.6.
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> tools/testing/selftests/kvm/kvm_page_table_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/kvm_page_table_test.c b/tools/testing/selftests/kvm/kvm_page_table_test.c
> index b3b00be1ef82..69f26d80c821 100644
> --- a/tools/testing/selftests/kvm/kvm_page_table_test.c
> +++ b/tools/testing/selftests/kvm/kvm_page_table_test.c
> @@ -200,7 +200,7 @@ static void *vcpu_worker(void *data)
> if (READ_ONCE(host_quit))
> return NULL;
>
> - clock_gettime(CLOCK_MONOTONIC_RAW, &start);
> + clock_gettime(CLOCK_MONOTONIC, &start);
> ret = _vcpu_run(vcpu);
> ts_diff = timespec_elapsed(start);
>
> @@ -367,7 +367,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
> /* Test the stage of KVM creating mappings */
> *current_stage = KVM_CREATE_MAPPINGS;
>
> - clock_gettime(CLOCK_MONOTONIC_RAW, &start);
> + clock_gettime(CLOCK_MONOTONIC, &start);
> vcpus_complete_new_stage(*current_stage);
> ts_diff = timespec_elapsed(start);
>
> @@ -380,7 +380,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
>
> *current_stage = KVM_UPDATE_MAPPINGS;
>
> - clock_gettime(CLOCK_MONOTONIC_RAW, &start);
> + clock_gettime(CLOCK_MONOTONIC, &start);
> vcpus_complete_new_stage(*current_stage);
> ts_diff = timespec_elapsed(start);
>
> @@ -392,7 +392,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
>
> *current_stage = KVM_ADJUST_MAPPINGS;
>
> - clock_gettime(CLOCK_MONOTONIC_RAW, &start);
> + clock_gettime(CLOCK_MONOTONIC, &start);
> vcpus_complete_new_stage(*current_stage);
> ts_diff = timespec_elapsed(start);
>
> --
> 2.27.0
>
next prev parent reply other threads:[~2023-08-02 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 2:24 [PATCH] KVM: selftests: use unified time type for comparison Bibo Mao
2023-08-02 19:30 ` Sean Christopherson [this message]
2023-08-02 19:52 ` Oliver Upton
2023-08-02 21:11 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMqu43iUfA/LsxlD@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maobibo@loongson.cn \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox