From: Sean Christopherson <seanjc@google.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
linux-kselftest@vger.kernel.org,
David Matlack <dmatlack@google.com>
Subject: Re: [PATCH 2/4] KVM: selftests: x86: Use TAP interface in the sync_regs test
Date: Wed, 2 Aug 2023 14:31:29 -0700 [thread overview]
Message-ID: <ZMrLMYxj3s+vHGrQ@google.com> (raw)
In-Reply-To: <ZMq0nYYDbOX1cOKN@google.com>
On Wed, Aug 02, 2023, Sean Christopherson wrote:
> Oh, and no need to post "KVM: selftests: Rename the ASSERT_EQ macro" in the next
> version, I'm planning on grabbing that one straightaway.
After paging this all back in...
I would much prefer that we implement the KVM specific macros[*], e.g. KVM_ONE_VCPU_TEST(),
and build on top of those. I'm definitely ok doing a "slow" conversion, i.e. starting
with a few easy tests. IIRC at some point I said I strongly preferred an all-or-nothing
approach, but realistically I don't think we'll make progress anytime soon if we try to
boil the ocean.
But I do think we should spend the time to implement the infrastructure right away. We
may end up having to tweak the infrastructure down the road, e.g. to convert other tests,
but I would rather do that then convert some tests twice.
[*] https://lore.kernel.org/all/Y2v+B3xxYKJSM%2FfH@google.com
next prev parent reply other threads:[~2023-08-02 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 7:59 [PATCH 0/4] Use TAP in some more x86 KVM selftests Thomas Huth
2023-07-12 7:59 ` [PATCH 1/4] KVM: selftests: Rename the ASSERT_EQ macro Thomas Huth
2023-07-18 12:26 ` Philippe Mathieu-Daudé
2023-07-12 7:59 ` [PATCH 2/4] KVM: selftests: x86: Use TAP interface in the sync_regs test Thomas Huth
2023-08-02 19:55 ` Sean Christopherson
2023-08-02 21:31 ` Sean Christopherson [this message]
2023-08-03 5:23 ` Thomas Huth
2023-08-03 5:17 ` Thomas Huth
2023-07-12 7:59 ` [PATCH 3/4] KVM: selftests: x86: Use TAP interface in the fix_hypercall test Thomas Huth
2023-07-12 7:59 ` [PATCH 4/4] KVM: selftests: x86: Use TAP interface in the userspace_msr_exit test Thomas Huth
2023-07-18 12:26 ` Philippe Mathieu-Daudé
2023-08-02 22:01 ` [PATCH 0/4] Use TAP in some more x86 KVM selftests Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMrLMYxj3s+vHGrQ@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox