From: Sean Christopherson <seanjc@google.com>
To: Metin Kaya <metikaya@amazon.co.uk>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, x86@kernel.org,
bp@alien8.de, dwmw@amazon.co.uk, paul@xen.org,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v3] KVM: x86/xen: Implement hvm_op/HVMOP_flush_tlbs hypercall
Date: Thu, 3 Aug 2023 17:22:05 -0700 [thread overview]
Message-ID: <ZMxErVeAj2HPZcPc@google.com> (raw)
In-Reply-To: <20230418101306.98263-1-metikaya@amazon.co.uk>
On Tue, Apr 18, 2023, Metin Kaya wrote:
> Implement in-KVM support for Xen's HVMOP_flush_tlbs hypercall, which
> allows the guest to flush all vCPU's TLBs. KVM doesn't provide an
> ioctl() to precisely flush guest TLBs, and punting to userspace would
> likely negate the performance benefits of avoiding a TLB shootdown in
> the guest.
>
> Signed-off-by: Metin Kaya <metikaya@amazon.co.uk>
>
> ---
> v3:
> - Addressed comments for v2.
> - Verified with XTF/invlpg test case.
>
> v2:
> - Removed an irrelevant URL from commit message.
> ---
I had applied this and even generated the "thank you", but then I actually ran
the KUT access test[*]. It may very well be a pre-existing bug, but that doesn't
change the fact that this patch breaks a test.
I apologize for being snippy, especially if it turns out this is unique to HSW
(or worse, my system), and your systems don't exhibit issues. Getting the test
to run took way too long and I'm bit grumpy.
Anyways, whatever is going wrong needs to be sorted out before this can be applied.
[*] https://lore.kernel.org/all/ZMxDRg6gWsVLeYFL@google.com
next prev parent reply other threads:[~2023-08-04 0:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230417122206.34647-1-metikaya@amazon.co.uk>
2023-04-17 12:22 ` [PATCH v2] KVM: x86/xen: Implement hvm_op/HVMOP_flush_tlbs hypercall Metin Kaya
2023-04-17 16:31 ` Sean Christopherson
2023-04-18 9:14 ` [EXTERNAL][PATCH " David Woodhouse
2023-04-18 10:13 ` [PATCH v3] " Metin Kaya
2023-04-18 10:48 ` Paul Durrant
2023-04-18 11:04 ` Kaya, Metin
2023-04-18 11:13 ` Paul Durrant
2023-04-18 11:05 ` [EXTERNAL][PATCH " David Woodhouse
2023-05-26 20:32 ` [PATCH " Sean Christopherson
2023-07-25 12:56 ` David Woodhouse
2023-07-26 20:07 ` Sean Christopherson
2023-07-27 12:04 ` David Woodhouse
2023-07-28 7:31 ` Kaya, Metin
2023-08-04 0:22 ` Sean Christopherson [this message]
2023-04-18 14:44 ` [EXTERNAL][PATCH v2] " Sean Christopherson
2023-04-18 15:47 ` David Woodhouse
2023-04-18 16:08 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMxErVeAj2HPZcPc@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=metikaya@amazon.co.uk \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).