From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6650C41513 for ; Wed, 16 Aug 2023 22:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346889AbjHPW0B (ORCPT ); Wed, 16 Aug 2023 18:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346886AbjHPWZo (ORCPT ); Wed, 16 Aug 2023 18:25:44 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA44FE56 for ; Wed, 16 Aug 2023 15:25:43 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-68874dec6c6so2606761b3a.1 for ; Wed, 16 Aug 2023 15:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692224743; x=1692829543; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=X/nvOfm2IHa8qd34Vr3L4gXJVYEcuL8LeF4EihusksQ=; b=veb1brBgyucQ4nd5xpDlx8YFM6NsMMoCuJ2+FbLmZn6qaU5hi0RBaM1pLa1G4sfjf7 jbZWow6GK/0tgQSapfsH1QAMM55d/HZTS1gEPaaW1Ffm+LJcwGcUpnxx86CxJq9PAGvE awLcD2vI5nJgVpOitZDcMBYAM24zfv10ZUwFeWmr9AOtVcOFMrmwsOMaNtx5wsagL5dl brfmajkMARTL3BcQidu2HfZa7XyAl6wFxfWTV3aWxagpF5ga/akjOiBxQXxFh60iW8iJ lUbrwTsavzSP98mWB2c7KTeQv+rgAJadbRX/XDUzkSDibJWnxG1ZNhSU5pNPbBfZ9NQZ s3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692224743; x=1692829543; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X/nvOfm2IHa8qd34Vr3L4gXJVYEcuL8LeF4EihusksQ=; b=f19xYlezRa4Z1KKT3QVzGIGjiqkhu5kkmpx9ar1AVpCAL9riCmlUKUfEx9HixcyEvk 6FKkoSC7ceB5UXc6VnElOUF5vLB7d0bI/5b3TZ6dau5t5m75ZcEIoH49HeVJp0Cu/rdZ RS8a953fBJ00NMVYjv2Cjw9TdIZcvHvfo7pr8HmqehC6h5zMs5qDk82qiX7vWoIQKKX6 8N7sDX2G40laBFHbRh5vJNGuksiofcGyZX4jbol5IxXikaKP+kDerrg6IAYkKnB3B2uM j/aQf2V3qjpeIu7hzHAoe1gDnq9d3fBF/X2XOy5o1HtZvEJn3bu4oK8wrLNHuXobK9oB z8qQ== X-Gm-Message-State: AOJu0YyxN8JUtRPFieZRB1NHC1k4Jezet7uW59ipggRCi/s/kR6bYTS6 +oLoiojWQe3bV6rl2J/Qw+IkqarCpt0= X-Google-Smtp-Source: AGHT+IFa9PZ62sECu8cthHE3iQeobMe1F3rchpz89myrvVrd6R0lfn1gFbOFZOzFka7RMDuuRIPSQR/9Hbk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:1393:b0:682:140c:2459 with SMTP id t19-20020a056a00139300b00682140c2459mr1500308pfg.0.1692224743379; Wed, 16 Aug 2023 15:25:43 -0700 (PDT) Date: Wed, 16 Aug 2023 15:25:41 -0700 In-Reply-To: <20230719144131.29052-1-binbin.wu@linux.intel.com> Mime-Version: 1.0 References: <20230719144131.29052-1-binbin.wu@linux.intel.com> Message-ID: Subject: Re: [PATCH v10 0/9] Linear Address Masking (LAM) KVM Enabling From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, chao.gao@intel.com, kai.huang@intel.com, David.Laight@aculab.com, robert.hu@linux.intel.com, guang.zeng@intel.com Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 19, 2023, Binbin Wu wrote: > Binbin Wu (7): > KVM: x86/mmu: Use GENMASK_ULL() to define __PT_BASE_ADDR_MASK > KVM: x86: Add & use kvm_vcpu_is_legal_cr3() to check CR3's legality > KVM: x86: Use KVM-governed feature framework to track "LAM enabled" > KVM: x86: Virtualize CR3.LAM_{U48,U57} > KVM: x86: Introduce get_untagged_addr() in kvm_x86_ops and call it in > emulator > KVM: VMX: Implement and wire get_untagged_addr() for LAM > KVM: x86: Untag address for vmexit handlers when LAM applicable > > Robert Hoo (2): > KVM: x86: Virtualize CR4.LAM_SUP > KVM: x86: Expose LAM feature to userspace VMM Looks good, just needs a bit of re-organination. Same goes for the LASS series. For the next version, can you (or Zeng) send a single series for LAM and LASS? They're both pretty much ready to go, i.e. I don't expect one to hold up the other at this point, and posting a single series will reduce the probability of me screwing up a conflict resolution or missing a dependency when applying. Lastly, a question: is there a pressing need to get LAM/LASS support merged _now_? E.g. are there are there any publicly available CPUs that support LAM and/or LASS? If not, I'll wait until v6.7 to grab these, e.g. so that you don't have to rush madly to turn around the next version, and so that I'm not trying to squeeze too much stuff in just before the merge window.