From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609D5C64EAE for ; Thu, 17 Aug 2023 20:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355056AbjHQUyG (ORCPT ); Thu, 17 Aug 2023 16:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355065AbjHQUxi (ORCPT ); Thu, 17 Aug 2023 16:53:38 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB80A35B6 for ; Thu, 17 Aug 2023 13:53:33 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-589f437fef0so2884407b3.3 for ; Thu, 17 Aug 2023 13:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692305613; x=1692910413; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ljybATuWSbqmcibWUndDogW5Y0plwtBc+lCyiblyYw4=; b=k8tkFeoESpIBm6Q+udwluVr3e5YqNzb/Lkr1Qw/uBsgo4VVePmhXbPYXE5MSh7m1eL Vrb1Cw1E6SlIsn16tG2KVPeFQe0CqZaEoWgphHnZctIvR2QqgQKM/vriZGPYHjtsKTym 4jWvMHJurRfGauhrPSPtereJREILf9FysF9IpFaI64a1bfCzswV8k40D7igblL0BcvLJ eh4raNykfp9fzfCUKJF+5IBn69brzTsGJp8557u9IxfrLOaKFHINHoxtlPsQhtFRfeCP ha4o+H40uDv2raAxT7BxgClTuDxeScTCsP8xd20Yk60P/cDkYDASUats8lop3IEedyD4 nubg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692305613; x=1692910413; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ljybATuWSbqmcibWUndDogW5Y0plwtBc+lCyiblyYw4=; b=WkdrIvlkTCmsd8wPIDrcZ20isen0YlFx6G2QDYcZxHI6ewJcUEUJIlPGtLkesFtkjh xdMyS+yQTKHWZPScATe+k9UMael+s6+aJz6cji2SjLN2CB6crwVXvZm0NgBnakiE6uP2 38gh9pymQvA5r9922OWInd7JOcYCKxRufdKMe9MsVQLTfOlC32/dmisUNVIOeyY//yCm NCeyhTtkGb8+Caax/n4K3lWNgDfZyFPfKx68IovZrg5TWshjseOPo42NYMIAy43eR63G j3WPN5bFXagzwLNrf15CeOvWvvz/lU2uzuqSccaLGrewoQWVsVnz5OcxL48AEG2co7kw /ufA== X-Gm-Message-State: AOJu0YzeNfCNPwlFKfLFe/4mzYhWr55nVXxw9SqurtgERdt1R8qc3pit DRMUC6opsJ81497Dh+Ju4ijicRY89iU= X-Google-Smtp-Source: AGHT+IFo7906WTHrxxZj9RUs2ONt+vA5DOr/hlq8cAehDvSfNTD1SHFH/KLFzVD1jYuA/jz8SvfypUDZXg4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ab54:0:b0:c6a:caf1:e601 with SMTP id u78-20020a25ab54000000b00c6acaf1e601mr9138ybi.13.1692305613170; Thu, 17 Aug 2023 13:53:33 -0700 (PDT) Date: Thu, 17 Aug 2023 13:53:31 -0700 In-Reply-To: <20230810090945.16053-4-cloudliang@tencent.com> Mime-Version: 1.0 References: <20230810090945.16053-1-cloudliang@tencent.com> <20230810090945.16053-4-cloudliang@tencent.com> Message-ID: Subject: Re: [PATCH v6 3/6] KVM: selftests: Introduce __kvm_pmu_event_filter to improved event filter settings From: Sean Christopherson To: Jinrong Liang Cc: Paolo Bonzini , Isaku Yamahata , Jim Mattson , Shuah Khan , Aaron Lewis , David Matlack , Vishal Annapurve , Wanpeng Li , Like Xu , Jinrong Liang , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Aug 10, 2023, Jinrong Liang wrote: > -static int run_filter_test(struct kvm_vcpu *vcpu, const uint64_t *events, > - int nevents, uint32_t flags) > +static int do_vcpu_set_pmu_event_filter(struct kvm_vcpu *vcpu, > + struct __kvm_pmu_event_filter *__f) Just "set_pmu_event_filter()" please. The "do" is pointless, and the "vcpu" part is confusing since the filter is per-VM, the selftest just happens to pass around the vCPU. And to be consistent with set_pmu_single_event_filter(). No need for a new version, I'll fixup when applying.