From: Jason Gunthorpe <jgg@nvidia.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>
Cc: Baolu Lu <baolu.lu@linux.intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: Re: [PATCH v5 3/4] iommufd: Add IOMMU_GET_HW_INFO
Date: Tue, 8 Aug 2023 10:02:42 -0300 [thread overview]
Message-ID: <ZNI88hEKdIt7QJHJ@nvidia.com> (raw)
In-Reply-To: <DS0PR11MB7529E1B07B438DA42B0C9F81C30CA@DS0PR11MB7529.namprd11.prod.outlook.com>
On Mon, Aug 07, 2023 at 08:49:27AM +0000, Liu, Yi L wrote:
> > > > + /* driver has hw_info callback should have a unique hw_info_type */
> > > > + if (WARN_ON_ONCE(hw_info_type == IOMMU_HW_INFO_TYPE_NONE)) {
> > > > + rc = -ENODEV;
> > > > + goto out_err;
> > > > + }
> > > > +
> > > > + length = min(cmd->data_len, data_len);
> > > > + if (copy_to_user(user_ptr, data, length)) {
> > > > + rc = -EFAULT;
> > > > + goto out_err;
> > > > + }
> > > > +
> > > > +done:
> >
> > No label here, put it in a if {}
>
> How about below?
Looks better
You could also consider putting the content of the if {} in a function
Jason
next prev parent reply other threads:[~2023-08-08 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:31 [PATCH v5 0/4] iommufd: Add iommu hardware info reporting Yi Liu
2023-08-03 14:31 ` [PATCH v5 1/4] iommu: Move dev_iommu_ops() to private header Yi Liu
2023-08-03 14:31 ` [PATCH v5 2/4] iommu: Add new iommu op to get iommu hardware information Yi Liu
2023-08-04 2:58 ` Liu, Jingqi
2023-08-04 6:36 ` Liu, Yi L
2023-08-03 14:31 ` [PATCH v5 3/4] iommufd: Add IOMMU_GET_HW_INFO Yi Liu
2023-08-04 1:59 ` Baolu Lu
2023-08-04 6:35 ` Liu, Yi L
2023-08-04 14:12 ` Jason Gunthorpe
2023-08-07 8:49 ` Liu, Yi L
2023-08-08 13:02 ` Jason Gunthorpe [this message]
2023-08-08 15:36 ` Liu, Yi L
2023-08-03 14:31 ` [PATCH v5 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW_INFO ioctl Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNI88hEKdIt7QJHJ@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox