From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF87EC6FA8F for ; Wed, 30 Aug 2023 18:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236186AbjH3ScY (ORCPT ); Wed, 30 Aug 2023 14:32:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242279AbjH3HtN (ORCPT ); Wed, 30 Aug 2023 03:49:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CFA12D for ; Wed, 30 Aug 2023 00:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693381695; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6OfCyRIQgh7H7wL/M4F+avKR6APj87bZXhcAT8LxgUI=; b=deo/f5wslE06j4nHUSJItQuxG6F1ycDLNDhsrlr9Skn6A0DT1HNI+ZKJOHUZH6xP+ZJ2zt 8KkFf9uNtnvvmgT66eVHZ8eXAg04zxckTIZyOAMiiyr9Qk6lmucGJhDmcdBxibtpgN15Qg QWOE9L4iI6guKjsSlh2bldn6/Sz46FA= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-4Z6p0HkgMhuX25KfugmTZQ-1; Wed, 30 Aug 2023 03:48:13 -0400 X-MC-Unique: 4Z6p0HkgMhuX25KfugmTZQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B5B153C0D858; Wed, 30 Aug 2023 07:48:12 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F01E01121315; Wed, 30 Aug 2023 07:48:09 +0000 (UTC) Date: Wed, 30 Aug 2023 08:48:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Chenyi Qiang , Markus Armbruster , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , Ani Sinha , Peter Xu , David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Marcelo Tosatti , Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Laszlo Ersek , Isaku Yamahata , erdemaktas@google.com Subject: Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230818095041.1973309-1-xiaoyao.li@intel.com> <20230818095041.1973309-42-xiaoyao.li@intel.com> <87wmxn6029.fsf@pond.sub.org> <11130e51-72fe-a07a-767b-f768611cf0d9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11130e51-72fe-a07a-767b-f768611cf0d9@intel.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 30, 2023 at 01:57:59PM +0800, Xiaoyao Li wrote: > On 8/30/2023 1:18 PM, Chenyi Qiang wrote: > > > > > > On 8/29/2023 6:25 PM, Daniel P. Berrangé wrote: > > > On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: > > > > > > > > > > > > On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: > > > > > On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: > > > > > > Xiaoyao Li writes: > > > > > > > > > > > > > From: Isaku Yamahata > > > > > > > > > > > > > > For GetQuote, delegate a request to Quote Generation Service. Add property > > > > > > > of address of quote generation server and On request, connect to the > > > > > > > server, read request buffer from shared guest memory, send the request > > > > > > > buffer to the server and store the response into shared guest memory and > > > > > > > notify TD guest by interrupt. > > > > > > > > > > > > > > "quote-generation-service" is a property to specify Quote Generation > > > > > > > Service(QGS) in qemu socket address format. The examples of the supported > > > > > > > format are "vsock:2:1234", "unix:/run/qgs", "localhost:1234". > > > > > > > > > > > > > > command line example: > > > > > > > qemu-system-x86_64 \ > > > > > > > -object 'tdx-guest,id=tdx0,quote-generation-service=localhost:1234' \ > > > > > > > -machine confidential-guest-support=tdx0 > > > > > > > > > > > > > > Signed-off-by: Isaku Yamahata > > > > > > > Signed-off-by: Xiaoyao Li > > > > > > > --- > > > > > > > qapi/qom.json | 5 +- > > > > > > > target/i386/kvm/tdx.c | 380 ++++++++++++++++++++++++++++++++++++++++++ > > > > > > > target/i386/kvm/tdx.h | 7 + > > > > > > > 3 files changed, 391 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/qapi/qom.json b/qapi/qom.json > > > > > > > index 87c1d440f331..37139949d761 100644 > > > > > > > --- a/qapi/qom.json > > > > > > > +++ b/qapi/qom.json > > > > > > > @@ -879,13 +879,16 @@ > > > > > > > # > > > > > > > # @mrownerconfig: MROWNERCONFIG SHA384 hex string of 48 * 2 length (default: 0) > > > > > > > # > > > > > > > +# @quote-generation-service: socket address for Quote Generation Service(QGS) > > > > > > > +# > > > > > > > # Since: 8.2 > > > > > > > ## > > > > > > > { 'struct': 'TdxGuestProperties', > > > > > > > 'data': { '*sept-ve-disable': 'bool', > > > > > > > '*mrconfigid': 'str', > > > > > > > '*mrowner': 'str', > > > > > > > - '*mrownerconfig': 'str' } } > > > > > > > + '*mrownerconfig': 'str', > > > > > > > + '*quote-generation-service': 'str' } } > > > > > > > > > > > > Why not type SocketAddress? > > > > > > > > > > Yes, the code uses SocketAddress internally when it eventually > > > > > calls qio_channel_socket_connect_async(), so we should directly > > > > > use SocketAddress in the QAPI from the start. > > > > > > > > Any benefit to directly use SocketAddress? > > > > > > We don't want whatever code consumes the configuration to > > > do a second level of parsing to convert the 'str' value > > > into the 'SocketAddress' object it actually needs. > > > > > > QEMU has a long history of having a second round of ad-hoc > > > parsing of configuration and we've found it to be a serious > > > maintenence burden. Thus we strive to have everything > > > represented in QAPI using the desired final type, and avoid > > > the second round of parsing. > > > > Thanks for your explanation. > > > > > > > > > "quote-generation-service" here is optional, it seems not trivial to add > > > > and parse the SocketAddress type in QEMU command. After I change 'str' > > > > to 'SocketAddress' and specify the command like "-object > > > > tdx-guest,type=vsock,cid=2,port=1234...", it will report "invalid > > > > parameter cid". > > > > > > The -object parameter supports JSON syntax for this reason > > > > > > -object '{"qom-type":"tdx-guest","quote-generation-service":{"type": "vsock", "cid":"2","port":"1234"}}' > > > > > > libvirt will always use the JSON syntax for -object with a new enough > > > QEMU. > > > > The JSON syntax works for me. Then, we need to add some doc about using > > JSON syntax when quote-generation-service is required. > > This limitation doesn't look reasonable to me. > > @Daniel, > > Is it acceptable by QEMU community? This is the expected approach for object types which have non-scalar properties. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|