From: Chao Gao <chao.gao@intel.com>
To: Tao Su <tao1.su@linux.intel.com>
Cc: <kvm@vger.kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>,
<guang.zeng@intel.com>, <yi1.lai@intel.com>
Subject: Re: [PATCH 1/2] x86/apic: Introduce X2APIC_ICR_UNUSED_12 for x2APIC mode
Date: Mon, 4 Sep 2023 10:58:32 +0800 [thread overview]
Message-ID: <ZPVH2HlIt1K3c0Bz@chao-email> (raw)
In-Reply-To: <20230904013555.725413-2-tao1.su@linux.intel.com>
On Mon, Sep 04, 2023 at 09:35:54AM +0800, Tao Su wrote:
>According to SDM, bit12 of ICR is no longer BUSY bit but UNUSED bit in
>x2APIC mode, which is the only difference of lower ICR between xAPIC and
>x2APIC mode. To avoid ambiguity, introduce X2APIC_ICR_UNUSED_12 for
>x2APIC mode.
>
>Signed-off-by: Tao Su <tao1.su@linux.intel.com>
Please use scripts/get_maintainer.pl to help create the Cc/To lists.
I believe x86 maintainers should be copied for this patch.
>---
> arch/x86/include/asm/apicdef.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
>index 4b125e5b3187..ea2725738b81 100644
>--- a/arch/x86/include/asm/apicdef.h
>+++ b/arch/x86/include/asm/apicdef.h
>@@ -78,6 +78,7 @@
> #define APIC_INT_LEVELTRIG 0x08000
> #define APIC_INT_ASSERT 0x04000
> #define APIC_ICR_BUSY 0x01000
>+#define X2APIC_ICR_UNUSED_12 0x01000
> #define APIC_DEST_LOGICAL 0x00800
> #define APIC_DEST_PHYSICAL 0x00000
> #define APIC_DM_FIXED 0x00000
>--
>2.34.1
>
next prev parent reply other threads:[~2023-09-04 2:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 1:35 [PATCH 0/2] KVM: x86: Fix a WARN in kvm_apic_send_ipi() Tao Su
2023-09-04 1:35 ` [PATCH 1/2] x86/apic: Introduce X2APIC_ICR_UNUSED_12 for x2APIC mode Tao Su
2023-09-04 2:58 ` Chao Gao [this message]
2023-09-04 3:03 ` Tao Su
2023-09-04 1:35 ` [PATCH 2/2] KVM: x86: Clear X2APIC_ICR_UNUSED_12 after APIC-write VM-exit Tao Su
2023-09-04 2:46 ` Chao Gao
2023-09-04 3:00 ` Tao Su
2023-09-04 4:16 ` kernel test robot
2023-09-04 5:02 ` Tao Su
2023-09-05 23:03 ` Sean Christopherson
2023-09-06 5:07 ` Tao Su
2023-09-06 22:17 ` Sean Christopherson
2023-09-07 9:56 ` Tao Su
2023-09-24 13:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPVH2HlIt1K3c0Bz@chao-email \
--to=chao.gao@intel.com \
--cc=guang.zeng@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tao1.su@linux.intel.com \
--cc=yi1.lai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox