From: Yan Zhao <yan.y.zhao@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] KVM: x86/mmu: .change_pte() optimization in TDP MMU
Date: Thu, 7 Sep 2023 08:36:47 +0800 [thread overview]
Message-ID: <ZPkbH0FYzfPC3pMS@yzhao56-desk.sh.intel.com> (raw)
In-Reply-To: <ZPkemGED1QD7kgUo@google.com>
On Wed, Sep 06, 2023 at 05:51:36PM -0700, Sean Christopherson wrote:
> On Thu, Sep 07, 2023, Paolo Bonzini wrote:
> > On Tue, Sep 5, 2023 at 10:18 PM Sean Christopherson <seanjc@google.com> wrote:
> > > Ooh, actually, maybe we could do
> > >
> > > static bool <name_tbd> = !IS_ENABLED(CONFIG_KSM);
> > >
> > > and then cross our fingers that that doesn't regress some other funky setups.
> >
> > It probably breaks gvisor-like setups that use MAP_PRIVATE mmap for
> > memslots? It would instantly break CoW even if memory is never
> > written.
>
> Doh, I completely forgot about gvisor and the like.
>
> Yan, I don't think this is worth pursuing. My understanding is that only legacy,
> relatively slow devices need DMA32. And as Robin pointed out, swiotlb=force isn't
> something that's likely deployed and certainly isn't intended for performance
> sensitive environments.
Yes. Then will you reconsider my patch 2?
I think it can remove the second EPT violation for each page write and
doesn't break KSM, and COW.
prev parent reply other threads:[~2023-09-07 1:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 8:50 [PATCH 0/2] KVM: x86/mmu: .change_pte() optimization in TDP MMU Yan Zhao
2023-08-08 8:53 ` [PATCH 1/2] KVM: x86/mmu: Remove dead code in .change_pte() handler in x86 " Yan Zhao
2023-08-08 8:54 ` [PATCH 2/2] KVM: x86/mmu: prefetch SPTE directly in x86 TDP MMU's change_pte() handler Yan Zhao
2023-08-16 18:18 ` [PATCH 0/2] KVM: x86/mmu: .change_pte() optimization in TDP MMU Sean Christopherson
2023-08-17 0:00 ` Yan Zhao
2023-08-17 17:53 ` Sean Christopherson
2023-08-18 10:17 ` Yan Zhao
2023-08-18 13:46 ` Sean Christopherson
2023-09-04 7:03 ` Yan Zhao
2023-09-05 18:59 ` Sean Christopherson
2023-09-05 19:30 ` Linus Torvalds
2023-09-06 0:29 ` Robin Murphy
2023-09-06 14:44 ` Sean Christopherson
2023-09-06 16:18 ` Robin Murphy
2023-09-06 16:46 ` Sean Christopherson
2023-09-08 8:18 ` Christoph Hellwig
2023-09-05 20:18 ` Sean Christopherson
2023-09-06 1:51 ` Yan Zhao
2023-09-06 22:17 ` Paolo Bonzini
2023-09-07 0:51 ` Sean Christopherson
2023-09-07 0:36 ` Yan Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPkbH0FYzfPC3pMS@yzhao56-desk.sh.intel.com \
--to=yan.y.zhao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox