public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Steve Rutherford <srutherford@google.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	David.Kaplan@amd.com, jacobhxu@google.com,
	patelsvishal@google.com, bhillier@google.com
Subject: Re: [PATCH] x86/sev: Make early_set_memory_decrypted() calls page aligned
Date: Fri, 15 Sep 2023 13:59:28 +0200	[thread overview]
Message-ID: <ZQRHIN7as8f+PFeh@gmail.com> (raw)
In-Reply-To: <20230818233451.3615464-1-srutherford@google.com>


* Steve Rutherford <srutherford@google.com> wrote:

> early_set_memory_decrypted() assumes its parameters are page aligned.
> Non-page aligned calls result in additional pages being marked as
> decrypted via the encryption status hypercall, which results in
> consistent corruption of pages during live migration. Live
> migration requires accurate encryption status information to avoid
> migrating pages from the wrong perspective.
> 
> Fixes: 4716276184ec ("X86/KVM: Decrypt shared per-cpu variables when SEV is active")
> Signed-off-by: Steve Rutherford <srutherford@google.com>
> ---
>  arch/x86/kernel/kvm.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

I suppose this fix is going through the KVM tree, or should we pick it up
in the x86 tree?

Thanks,

	Ingo

  parent reply	other threads:[~2023-09-15 11:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 23:34 [PATCH] x86/sev: Make early_set_memory_decrypted() calls page aligned Steve Rutherford
2023-08-21  6:44 ` Gupta, Pankaj
2023-08-21 13:10 ` Tom Lendacky
2023-08-21 18:15   ` Steve Rutherford
2023-08-21 18:53     ` Tom Lendacky
2023-08-21 19:25       ` Steve Rutherford
2023-08-21 20:24         ` Tom Lendacky
2023-08-21 22:53           ` Steve Rutherford
2023-09-15 11:59 ` Ingo Molnar [this message]
2023-09-15 18:44   ` Steve Rutherford
2023-09-16  9:19     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQRHIN7as8f+PFeh@gmail.com \
    --to=mingo@kernel.org \
    --cc=David.Kaplan@amd.com \
    --cc=bhillier@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jacobhxu@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=patelsvishal@google.com \
    --cc=pbonzini@redhat.com \
    --cc=srutherford@google.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox