From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBDE5E92FD3 for ; Fri, 6 Oct 2023 01:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjJFBsY (ORCPT ); Thu, 5 Oct 2023 21:48:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjJFBsX (ORCPT ); Thu, 5 Oct 2023 21:48:23 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 139CED8 for ; Thu, 5 Oct 2023 18:48:22 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d817775453dso2121946276.2 for ; Thu, 05 Oct 2023 18:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696556901; x=1697161701; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pXc2O/7sCaxNCrmG6skLU9Fi8ZAb+bkQu9XTdeJPITM=; b=Id1JyKTE+DXe1zXADSJhMkgJCISFAetC0ZgprPpbixwdbVAHvTW2DZX+QEuizCEE63 NCsq12r4rPcHxYzTd3xfdnNrBWpBxaAUF4/ifkRs/eLZ9mFZMmUQQ4KH4ZfsXl8zOi2X HXELmdYhtOxeqEAuM46HzRpt5jq+BzOTK9jx3USTt4tbnYsqLmpqRCnGxb1gldIOpCnV NfBUsW6MZURpD45b1/ZNqux+CMV4BgoY+C9N1oJzeTHvSG9vlCO1U16pI3yOJ1SAitWR LK/qvppVra3/3Uf7vhFg4fnowzPZ4QveTtDL/t6DdBmRTQnCwwbOSofUAO076cksFG2q z16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696556901; x=1697161701; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pXc2O/7sCaxNCrmG6skLU9Fi8ZAb+bkQu9XTdeJPITM=; b=buDjJCBkQe6G+tVjJ1MIZPrjA16+23wKOTaCFdfW9z1d6zazbPXQDHCLX++pI/lPU1 kAznOZXygFHltRvakrZiFEmAwQLw5uTNZXRROvBgBpYfyTb8ooUGlxPdIRv9mxw6uZMR EozC3S/mW9GP2LlQOv60ldc1E1TXEDudXgEP3MJjrSHLmTNG+7+hr3k9Ov9X8pIrJ4EC d4L/xH1LLToCwiMXJJuQkMDMM0N+BNeMu65MfM4uacurdTFV1S+D3jkSLsUC3TJXzAof l/j/71Ir1wpMRGTF1CxKh4SgyDqZ7cbhdiUEXjkCxersqGL0Qca9LXsCMR4QjaMt+Y+O tuAA== X-Gm-Message-State: AOJu0YyxraYYGOv8mVUEecgJVnA+6RugBAmYAhU4f7ofzhcsUl4c/EiM GU+PMhxtM8vLTWV5KhwDB4F0OAaKO/w= X-Google-Smtp-Source: AGHT+IG5kNlkia9mNVTpbkW4qVJ+ISAXuag8oe/q6O2fyloXPP+UYEYfKbsxwZ6+HCaMsJtpRYwGXiuE5ss= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:500c:0:b0:d81:fc08:29ea with SMTP id e12-20020a25500c000000b00d81fc0829eamr89926ybb.2.1696556901326; Thu, 05 Oct 2023 18:48:21 -0700 (PDT) Date: Thu, 5 Oct 2023 18:48:19 -0700 In-Reply-To: <5fc0fbfe-72e8-44bf-bad2-92513f299832@xen.org> Mime-Version: 1.0 References: <20231004174628.2073263-1-paul@xen.org> <5fc0fbfe-72e8-44bf-bad2-92513f299832@xen.org> Message-ID: Subject: Re: [PATCH v2] KVM: x86/xen: ignore the VCPU_SSHOTTMR_future flag From: Sean Christopherson To: paul@xen.org Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Durrant , David Woodhouse , David Woodhouse , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , x86@kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 05, 2023, Paul Durrant wrote: > On 04/10/2023 19:30, Sean Christopherson wrote: > > On Wed, Oct 04, 2023, Paul Durrant wrote: > > > --- > > > Cc: David Woodhouse > > > Cc: Sean Christopherson > > > Cc: Paolo Bonzini > > > Cc: Thomas Gleixner > > > Cc: Ingo Molnar > > > Cc: Borislav Petkov > > > Cc: Dave Hansen > > > Cc: "H. Peter Anvin" > > > Cc: x86@kernel.org > > > > If you're going to manually Cc folks, put the Cc's in the changelog proper so that > > there's a record of who was Cc'd on the patch. > > > > FTR, the basic list was generated: > > ./scripts/get_maintainer.pl --no-rolestats > 0001-KVM-xen-ignore-the-VCPU_SSHOTTMR_future-flag.patch | while read line; > do echo Cc: $line; done > > and then lightly hacked put x86 at the end and remove my own name... so not > really manual. > Also not entirely sure why you'd want the Cc list making it into the actual > commit. It's useful for Cc's that *don't* come from get_maintainers, as it provides a record in the commit of who was Cc'd on a patch. E.g. if someone encounters an issue with a commit, the Cc records provide additional contacts that might be able to help sort things out. Or if a maintainer further up the stream has questions or concerns about a pull request, they can use the Cc list to grab the right audience for a discussion, or be more confident in merging the request because the maintainer knows that the "right" people at least saw the patch. Lore links provide much of that functionality, but following a link is almost always slower, and some maintainers are allergic to web browsers :-) > > Or even better, just use scripts/get_maintainers.pl and only manually Cc people > > when necessary. > > I guess this must be some other way of using get_maintainers.pl that you are > expecting? Ah, I was just assuming that you were handcoding the Cc "list", but it sounds like you're piping the results into each patch. That's fine, just a bit noisy and uncommon. FWIW, my scripts gather the To/Cc for all patches in a series, and then use the results for the entire series, e.g. git send-email --confirm=always --suppress-cc=all $to $bcc $cc ... That way everyone that gets sent mail gets all patches in a series. Most contributors, myself included, don't like to receive bits and pieces of a series, e.g. it makes doing quick triage/reviews annoying, especially if the patches I didn't receive weren't sent to any of the mailing list to which I'm subscribed.