From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5EACE732DE for ; Thu, 28 Sep 2023 14:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbjI1OhX (ORCPT ); Thu, 28 Sep 2023 10:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbjI1OhW (ORCPT ); Thu, 28 Sep 2023 10:37:22 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FCE2136 for ; Thu, 28 Sep 2023 07:37:20 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1c73fb50da6so1882485ad.0 for ; Thu, 28 Sep 2023 07:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695911839; x=1696516639; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1QxaDNo/28khXZb4Aj1sVc9pIXz3hTbsT3xVR2UV8m8=; b=rknJhIbokgH0zbGE2DpHc7rvxjhI0qDOwPETMBTKXBj5ZrWZctMUe3PYldU/Uz4eMY piDcpdEf5e45m6PRCXYf3IZmVIsnbcMzOTYHw60xa75cxCwc4irYb0ngABf1pPhQ2nt6 cpFYxiEqwu35c8EzPQQ4+oMEH1M4boShG6855KHXGH9K1Cx0zhyG+RVVBEfv/dENM/gH nbP4odRaqR6cWmGp7xQJrKdbl4Ns3EhyvwFV+l8UFmEGnhKA1t9s62/TiAqZMBVa4eKS BlwFoLwbpAx5lFCZPIXGbVNF49VzPN13od7Sr0IWxpkVYOjA1scNIe1L7LugvIxapZm1 A6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695911839; x=1696516639; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1QxaDNo/28khXZb4Aj1sVc9pIXz3hTbsT3xVR2UV8m8=; b=xMjlkBOmW2HGGo1tdp3qObLb+Ow8jr8BSrh1C1QYOJHhof/HWj9hO58zuvb+RBOE+b grZ40+CVo0ao6jSl1l+JR+tHKkbXgHNasiJseDkMxhEls0YIyLoozbTGg1NCpjxU9puc 1/qWwHKfk84iWiL2Rigro1OBWjMO6mkCc/TF47WQnpnlk5RXXofl0WmoQamGZLAwxhjF lp/FACU2ZBYPGuB4gxf9sKlCM6VpJdZpYgwwOYALSWxdMawhu89WEV+559HEHf8eC5aB FbFGkGcskPH6qZbjFqwn8YviPCzfiRa8HavsKHIsMBY2SuiSvWoNi/3KDCI+HuJ+UF8L Mctg== X-Gm-Message-State: AOJu0Yw1CIaiacWXV3PCukIB+w/HK4M0ZMRUPhLFyFTu1+kvbRCHRaHt ABDfV8VpWgECXJM3i23cbi5toXcDpp0= X-Google-Smtp-Source: AGHT+IFjf4/4kxY62aGAWySYok0JrBMvXVo3onhQW53llL5R1mbFzYHYE6agELo+DEZDG1+PprgDhHr6p74= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:f543:b0:1c7:2763:9ed7 with SMTP id h3-20020a170902f54300b001c727639ed7mr23179plf.9.1695911839637; Thu, 28 Sep 2023 07:37:19 -0700 (PDT) Date: Thu, 28 Sep 2023 07:37:17 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230814222358.707877-1-mhal@rbox.co> <20230814222358.707877-4-mhal@rbox.co> <13480bef-2646-4c01-ba81-3020a2ef2ce1@rbox.co> Message-ID: Subject: Re: [PATCH 3/3] KVM: Correct kvm_vcpu_event(s) typo in KVM API documentation From: Sean Christopherson To: Michal Luczaj Cc: pbonzini@redhat.com, corbet@lwn.net, kvm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 28, 2023, Michal Luczaj wrote: > On 9/27/23 22:10, Sean Christopherson wrote: > > On Tue, Aug 15, 2023, Michal Luczaj wrote: > >> On 8/15/23 00:08, Michal Luczaj wrote: > >>> I understand that typo fixes are not always welcomed, but this > >>> kvm_vcpu_event(s) did actually bit me, causing minor irritation. > >> ^^^ > > > > FWIW, my bar for fixing typos is if the typo causes any amount of confusion or > > wasted time. If it causes one person pain, odds are good it'll cause others pain > > in the future. > > OK, do you want me to resend just the kvm_vcpu_event(s) fix? > (and, empathetically, introduce a typo in the changelog proper :P) Oh, no, sorry. I'll take this as-is. Opportunistically fixing misspellings like you did it totally fine, especially since this is documentation. What I was trying to say is that if a patch fixes a real issue for someone, I'll definitely take the time to get it applied. I didn't mean to say I wouldn't take other typo fixes (though I am inclined to leave code/comments alone if a typo is benign, in order to reduce the churn in git history).