From: Sean Christopherson <seanjc@google.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com,
maz@kernel.org, oliver.upton@linux.dev
Subject: Re: [PATCH] KVM: selftests: Drop newline from __TEST_REQUIRE
Date: Thu, 30 Nov 2023 19:16:28 +0000 [thread overview]
Message-ID: <ZWjfjAnZcomGa1Ey@google.com> (raw)
In-Reply-To: <20231130182832.54603-2-ajones@ventanamicro.com>
On Thu, Nov 30, 2023, Andrew Jones wrote:
> A few __TEST_REQUIRE callers are appending their own newline, resulting
> in an extra one being output. Rather than remove the newlines from
> those callers, remove it from __TEST_REQUIRE and add newlines to all
> the other callers, as __TEST_REQUIRE was the only output function
> appending newlines and consistency is a good thing.
>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> ---
>
> Applies to kvm-x86/selftests (I chose that branch to ensure I got the
> MAGIC_TOKEN change)
Heh, and then I went and created a conflict anyways :-)
https://lore.kernel.org/all/20231129224042.530798-1-seanjc@google.com
If there are no objections, I'll grab this in kvm-x86/selftests and sort out the
MAGIC_TOKEN conflict.
next prev parent reply other threads:[~2023-11-30 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 18:28 [PATCH] KVM: selftests: Drop newline from __TEST_REQUIRE Andrew Jones
2023-11-30 19:16 ` Sean Christopherson [this message]
2023-12-01 9:26 ` Andrew Jones
2023-12-01 16:08 ` Sean Christopherson
2023-12-02 8:12 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWjfjAnZcomGa1Ey@google.com \
--to=seanjc@google.com \
--cc=ajones@ventanamicro.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox