From: Sean Christopherson <seanjc@google.com>
To: zhaotianrui <zhaotianrui@loongson.cn>
Cc: Shuah Khan <shuah@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Vishal Annapurve <vannapurve@google.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
loongarch@lists.linux.dev, Peter Xu <peterx@redhat.com>,
Vipin Sharma <vipinsh@google.com>,
maobibo@loongson.cn
Subject: Re: [PATCH v5 1/4] KVM: selftests: Add KVM selftests header files for LoongArch
Date: Tue, 12 Dec 2023 09:18:14 -0800 [thread overview]
Message-ID: <ZXiV1rMrXY0hNgvZ@google.com> (raw)
In-Reply-To: <e40d3884-bf39-8286-627f-e0ce7dacfcbe@loongson.cn>
On Tue, Dec 12, 2023, zhaotianrui wrote:
> Hi, Sean:
>
> I want to change the definition of DEFAULT_GUEST_TEST_MEM in the common
> file "memstress.h", like this:
>
> /* Default guest test virtual memory offset */
> +#ifndef DEFAULT_GUEST_TEST_MEM
> #define DEFAULT_GUEST_TEST_MEM 0xc0000000
> +#endif
>
> As this address should be re-defined in LoongArch headers.
Why? E.g. is 0xc0000000 unconditionally reserved, not guaranteed to be valid,
something else?
> So, do you have any suggesstion?
Hmm, I think ideally kvm_util_base.h would define a range of memory that can be
used by tests for arbitrary data. Multiple tests use 0xc0000000, which is not
entirely arbitrary, i.e. it doesn't _need_ to be 0xc0000000, but 0xc0000000 is
convenient because it's 32-bit addressable and doesn't overlap reserved areas in
other architectures.
next prev parent reply other threads:[~2023-12-12 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 11:18 [PATCH v5 0/4] KVM: selftests: Add LoongArch support Tianrui Zhao
2023-11-30 11:18 ` [PATCH v5 1/4] KVM: selftests: Add KVM selftests header files for LoongArch Tianrui Zhao
2023-12-12 3:08 ` zhaotianrui
2023-12-12 17:18 ` Sean Christopherson [this message]
2023-12-13 7:15 ` zhaotianrui
2023-12-13 7:42 ` maobibo
2023-12-13 23:56 ` Sean Christopherson
2023-12-14 2:20 ` maobibo
2023-11-30 11:18 ` [PATCH v5 2/4] KVM: selftests: Add core KVM selftests support " Tianrui Zhao
2023-12-04 2:05 ` maobibo
2023-11-30 11:18 ` [PATCH v5 3/4] KVM: selftests: Add ucall test " Tianrui Zhao
2023-12-04 2:05 ` maobibo
2023-11-30 11:18 ` [PATCH v5 4/4] KVM: selftests: Add test cases " Tianrui Zhao
2023-12-04 2:11 ` maobibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXiV1rMrXY0hNgvZ@google.com \
--to=seanjc@google.com \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=vannapurve@google.com \
--cc=vipinsh@google.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox