From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D92211713 for ; Thu, 10 Apr 2025 23:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744327552; cv=none; b=MtTR3R9uGlICIoSD+Bg9W4c4Nclq/fi2f1hNpSd7QLqSiiluj9ZS9IEcUC1LUWmjJWAJ7JjyA6fLoOH6NZY3gAtqgjar89Aww6AnWWfxGbaS4YgTi02D6Xyl6yEmJ/Iycf83Mm0e4TrkCBlEJAxkI28Bz9wycisE2TH5wJFzyQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744327552; c=relaxed/simple; bh=H3TsOvV/0/nhWyZg2M7TYMQ+w/e4B+1Zkq90CxwF9W4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nqK/KCEvF8Zc45M8VdzMQzBI3smE7YN8s6/xbg4IgTzAPb+HBAslUOLjqDxQdoOOyBK2FfflMrpD5X0NDZdpt8EwT1hmfJlhCTv1aWL8CLQLFMezEXilobyVmdh4JqBXLI92xzde+9nXZq5h1hyOKx6blkplHcNl7yaTsgos6BQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hxAOJadv; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hxAOJadv" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2ff5296726fso1907570a91.0 for ; Thu, 10 Apr 2025 16:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744327550; x=1744932350; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=45GeH+UPAzqkTZWqY2D6RQOKWswLealJ3SJB/kaSl38=; b=hxAOJadvxY/o6qSJUrY3SgYg1u0rSD8gZ35fL/bINs3GQ3oJg19xhQdXxwhbzzEKXy Xuaol3ricT1ucLF8LwpHkksv4iY4awJ1fxlrXGAOtxRgyRbIQg8f1RYx5lJWHfOfUgjb SayB365bU2paywK395MkdqZTDpIbtr8f494ropcnS8aS+mFYMipvUcjV/MdLbrF5uVOr RhbtFatq/zf55Czy7Q/oyckcyPRTOOsOfntl0h7ZK3FJrB5AQ7nS4Z+K1hCeg6GvvmUv EMwiqLZne1ArWayDpPeKtK9LJfe6Q42doPQue09fO8C/gbz7eK6e1+9Ncq+D6BSd7Kqs U4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744327550; x=1744932350; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=45GeH+UPAzqkTZWqY2D6RQOKWswLealJ3SJB/kaSl38=; b=Yb8/ZGO+eSF6lz98BPqCpT9SJ8UtpvxMOmIIuttOK+Zgixu7BCohNuTBYrqT8qxM7M 2PryNwuE5hn8OeZaISqk86EDkMh/0NYIpHLJl/ncuuSIH48Ykesiw7SMIZEARmZA4/o5 nSQVwc3lsVdx36KFW38ZMygbO1Dag4e6kHJ+DgMf20bwS03Z/hIMnwzJKCBVth+su+S9 u48wgc0sIwMLQlta7TgtPk1rJCi1ashd5+xh44OM5oTz/Xutju8iuE0bvZWYhVjXnz29 1Xmc86pthOJzl4ro6gzwdIa5oNC9cRR7JK7BRgWv31f/hACDhNTcHc8CIDs8N+pOvxif kfEg== X-Forwarded-Encrypted: i=1; AJvYcCWP9YxAsUad/GqAnajfuoBajs8TiEc75aC8belSAwrpexTR4tWdJekiyD/X2PzdzeY8qFg=@vger.kernel.org X-Gm-Message-State: AOJu0YwvOO+0FmZGrbC/1u+6+Eir3Yjx5pcLLSVMgCsOR+f8WocMdQKO jn1goI7cxRALYEJB/0HDvIYOphE3g7Mk5Ab6XXLlTpkkdNdu0WgeVq97+cqE8zkITxpqxo4LY9A dJg== X-Google-Smtp-Source: AGHT+IEZ5sbPrSHp5oZ7gTc+BwY7HnP33HbH3PjY0vlVaCfeHGvod6/yAfGEhOKi6txlF/yqz03B5IxKNWI= X-Received: from pjbsh4.prod.google.com ([2002:a17:90b:5244:b0:2fa:2661:76ac]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2543:b0:2ea:bf1c:1e3a with SMTP id 98e67ed59e1d1-308236343e4mr1425746a91.12.1744327549848; Thu, 10 Apr 2025 16:25:49 -0700 (PDT) Date: Thu, 10 Apr 2025 16:25:48 -0700 In-Reply-To: <20250409092147.GAZ_Y8K52Opcw2X-tg@fat_crate.local> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250324130248.126036-1-manali.shukla@amd.com> <20250324130248.126036-3-manali.shukla@amd.com> <20250324215627.GBZ-HVC-KmZiTMxPr3@fat_crate.local> <55986a72-1be4-4e96-809c-dd004291df2e@amd.com> <20250409092147.GAZ_Y8K52Opcw2X-tg@fat_crate.local> Message-ID: Subject: Re: [PATCH v4 2/5] x86/cpufeatures: Add CPUID feature bit for the Bus Lock Threshold From: Sean Christopherson To: Borislav Petkov Cc: Manali Shukla , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, nikunj@amd.com, thomas.lendacky@amd.com Content-Type: text/plain; charset="us-ascii" On Wed, Apr 09, 2025, Borislav Petkov wrote: > On Wed, Apr 09, 2025 at 11:30:56AM +0530, Manali Shukla wrote: > > Do you have concern with the decision to expose the flag to /proc/cpuinfo? > > > > The decision to expose the flag to /proc/cpuinfo was already discussed in > > [v1]. As suggested in the discussion [v1], I have added "buslock" to be > > enumerated in /proc/cpuinfo. > > If you mean this: > > https://lore.kernel.org/kvm/20240709175145.9986-4-manali.shukla@amd.com/T/#m1dc7e08c54dd91d53a6bc5b1ed0a6721b356a756 > > I don't see any conclusion there. > > I see Sean wanting to export information out of KVM to say what it supports > without adding user ABI and I don't know how far that has come Not very far :-( > but what you're > doing here ain't it. > > Just do: > > #define X86_FEATURE_BUS_LOCK_THRESHOLD (15*32+29) /* Bus lock threshold */ > > and then later KVM can export this however it prefers. +1