From: Sean Christopherson <seanjc@google.com>
To: James Houghton <jthoughton@google.com>
Cc: kvm@vger.kernel.org, Maxim Levitsky <mlevitsk@redhat.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
mkoutny@suse.com, Yosry Ahmed <yosry.ahmed@linux.dev>,
Yu Zhao <yuzhao@google.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] KVM: selftests: Extract guts of THP accessor to standalone sysfs helpers
Date: Fri, 11 Apr 2025 14:12:38 -0700 [thread overview]
Message-ID: <Z_mFxiXcWKcxRo8g@google.com> (raw)
In-Reply-To: <20250331213025.3602082-2-jthoughton@google.com>
On Mon, Mar 31, 2025, James Houghton wrote:
> From: Sean Christopherson <seanjc@google.com>
>
> Extract the guts of thp_configured() and get_trans_hugepagesz() to
> standalone helpers so that the core logic can be reused for other sysfs
> files, e.g. to query numa_balancing.
>
> Opportunistically assert that the initial fscanf() read at least one byte,
> and add a comment explaining the second call to fscanf().
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Needs your SoB. It's a bit absurd for this particular patch, but please provide
it anyway, if only so that I can get a giggle out of the resulting chain of SoBs :-)
next prev parent reply other threads:[~2025-04-11 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 21:30 [PATCH v2 0/5] KVM: selftests: access_tracking_perf_test fixes for NUMA balancing and MGLRU James Houghton
2025-03-31 21:30 ` [PATCH v2 1/5] KVM: selftests: Extract guts of THP accessor to standalone sysfs helpers James Houghton
2025-04-11 21:12 ` Sean Christopherson [this message]
2025-04-11 23:13 ` James Houghton
2025-03-31 21:30 ` [PATCH v2 2/5] KVM: selftests: access_tracking_perf_test: Add option to skip the sanity check James Houghton
2025-03-31 21:30 ` [PATCH v2 3/5] cgroup: selftests: Move cgroup_util into its own library James Houghton
2025-03-31 22:02 ` Tejun Heo
2025-04-08 0:17 ` David Matlack
2025-04-09 23:04 ` James Houghton
2025-03-31 21:30 ` [PATCH v2 4/5] KVM: selftests: Build and link selftests/cgroup/lib into KVM selftests James Houghton
2025-03-31 21:30 ` [PATCH v2 5/5] KVM: selftests: access_tracking_perf_test: Use MGLRU for access tracking James Houghton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_mFxiXcWKcxRo8g@google.com \
--to=seanjc@google.com \
--cc=axelrasmussen@google.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=mlevitsk@redhat.com \
--cc=tj@kernel.org \
--cc=yosry.ahmed@linux.dev \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox