Re: [PATCH v1 07/26] x86/fault: Add helper for dumping RMP entries

Tom Lendacky
2024-01-10T15:51:10Z

On 1/10/24 09:27, Borislav Petkov wrote:
> On Wed, Jan 10, 2024 at 09:20:44AM -0600, Tom Lendacky wrote:
>> How about saying "... dumping all non-zero entries in the whole ..."
>
> I'm trying not to have long stories in printk statements :)

Well it only adds "non-zero"

>
>> and then removing the print below that prints the PFN and "..."
>
> Why remove the print? You want to print every non-null RMP entry in the
> 2M range, no?

I'm only suggesting getting rid of the else that prints "..." when the
entry is all zeroes. Printing the non-zero entries would still occur.

Thanks,
Tom

>
> And the "..." says that it is a null entry.
>