Re: [PATCH v1 13/26] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP

Borislav Petkov
2024-01-15T11:20:26Z

On Sat, Dec 30, 2023 at 10:19:41AM -0600, Michael Roth wrote:
> + /*
> + * The following sequence must be issued before launching the
> + * first SNP guest to ensure all dirty cache lines are flushed,
> + * including from updates to the RMP table itself via RMPUPDATE
> + * instructions:
> + *
> + * - WBINDV on all running CPUs
> + * - SEV_CMD_SNP_INIT[_EX] firmware command
> + * - WBINDV on all running CPUs
> + * - SEV_CMD_SNP_DF_FLUSH firmware command
> + */

Typos:

---
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 85634d4f8cfe..ce0c56006900 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -604,9 +604,9 @@ static int __sev_snp_init_locked(int *error)
* including from updates to the RMP table itself via RMPUPDATE
* instructions:
*
- * - WBINDV on all running CPUs
+ * - WBINVD on all running CPUs
* - SEV_CMD_SNP_INIT[_EX] firmware command
- * - WBINDV on all running CPUs
+ * - WBINVD on all running CPUs
* - SEV_CMD_SNP_DF_FLUSH firmware command
*/
wbinvd_on_all_cpus();

--
Regards/Gruss,
Boris.