Re: [PATCH v1 14/26] crypto: ccp: Provide API to issue SEV and SNP commands

Borislav Petkov
2024-01-17T09:49:27Z

On Sat, Dec 30, 2023 at 10:19:42AM -0600, Michael Roth wrote:
> +/**
> + * sev_do_cmd - issue an SEV or an SEV-SNP command
> + *
> + * @cmd: SEV or SEV-SNP firmware command to issue
> + * @data: arguments for firmware command
> + * @psp_ret: SEV command return code
> + *
> + * Returns:
> + * 0 if the SEV successfully processed the command

More forgotten feedback:

---
diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h
index 0581f194cdd0..a356a7b7408e 100644
--- a/include/linux/psp-sev.h
+++ b/include/linux/psp-sev.h
@@ -922,7 +922,7 @@ int sev_guest_decommission(struct sev_data_decommission *data, int *error);
* @psp_ret: SEV command return code
*
* Returns:
- * 0 if the SEV successfully processed the command
+ * 0 if the SEV device successfully processed the command
* -%ENODEV if the PSP device is not available
* -%ENOTSUPP if PSP device does not support SEV
* -%ETIMEDOUT if the SEV command timed out

---

Also, pls add it to your TODO list as a very low prio item to fixup all
this complains about:

./scripts/kernel-doc -none include/linux/psp-sev.h

Thx.

--
Regards/Gruss,
Boris.