Re: [PATCH v9 09/27] KVM: x86: Rename kvm_{g,s}et_msr() to menifest emulation operations

Chao Gao
2024-01-25T03:45:40Z

On Tue, Jan 23, 2024 at 06:41:42PM -0800, Yang Weijiang wrote:
>Rename kvm_{g,s}et_msr() to kvm_emulate_msr_{read,write}() to make it
>more obvious that KVM uses these helpers to emulate guest behaviors,
>i.e., host_initiated == false in these helpers.
>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

I think {kvm,emulator}_{g,s}et_msr_with_filter are equally confusing.
Maybe you can rename them as well.

Anyway, this patch looks good;

Reviewed-by: Chao Gao <chao.gao@intel.com>