From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4F77AE64 for ; Tue, 30 Jan 2024 23:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706657103; cv=none; b=Zd+tmqdLndfj6sDX+Vz3NrV0OEG1+GqI3iRewoJSjScXOpwfJQzueZpty7mMlE1wb+IelKR9JHa+2jo6KZgriZqRyTTfMDe+D9gC3cleCrhU0TXU7tLapVf2P3wXQRQYQPnpYEtLVpx2SUyU3hnFq+QpIwzMf88IZWafF2og8S8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706657103; c=relaxed/simple; bh=QLf5+s2EXzxM6NEMqH1PSQJKz8I1rG4C6C6q/v8c3r0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=s8ixA8Qb9By3bALMk3mV+cfCx0XnDK+RAdhNXPiLWar7URB4GejHn+qxBMl0IrlBW5WTJGukZbGPkzZMquk95rqhM45XQmikOdL56VYAxc5M40czCJIivqX6E5sK0kTWDoupzTLVerilQyAxxzDd8F5LANa7OCCYBuFQVsurWIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jWelPv54; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jWelPv54" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6bea4c8b9so109955276.3 for ; Tue, 30 Jan 2024 15:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706657100; x=1707261900; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+DZOnZhgrOi058fY32LTm4dCLP0HDk6nBa+5Ze3KMOU=; b=jWelPv54eDo7fZbkAfQdoYMNqSE9W2eURCcFAAA8KLVPJuYJWzkQ2xFgyJEQ0mx4GD Uh++H1LVRuFa36dYpXQBpL05IIBrupZHE2TN/+gQmWK/U9jtH7Rq+Su9qxcvQTZjK/8a 7pf+T6Wx3KLgEKoidtFNRXAhFxSZ/FcMOAO0SeUX4KEKH1ml9B3Axq5wREGlW2RSFeq/ 4p+31Xd0dhM4BcSonDkxvh14Dl5fYY9HV076SHQWnde3Zo3waw7uYCPTTMTkqz1H/Jc5 2vgZod7KZOJyJXb/zVMxmVNHfmi/SwwXItU7N29NwPzitsAdVLBtNwxIDCzRN5WhlLI1 E8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706657100; x=1707261900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+DZOnZhgrOi058fY32LTm4dCLP0HDk6nBa+5Ze3KMOU=; b=e55wsZjzZsMzcicYKLFI9pqwHv4A1etbubx2gng9hC8ZcXRD5SEtGVfwPC1M7eXN0e r1ohnDE63y3mBDZntSVK9GU55HIwjJjipTBmKIzQJvphRh9s/5e88FqCEjeHI0ukQR7m ufXeqorABB0WL3eNfQre9umJspUH/hftAwRjzus6qleqhfZzvIffl/3w7IOwUZAnT1RA nNlPRNQkLa11UYIesfCJHVLlGZG8w10uVWnKnGvXul8k9IqeYYjPfZIrrhveuRiGAskm y+ELytW83gUoN4iTPoaGHcpIGiueprn8/SllRI5GwZdYFUL0lp6240lmC/ohFGc13Cgi vJtw== X-Gm-Message-State: AOJu0YxJnrXnw2YMWmj7lroKfvAhe7bAbWYelqPSnBNHF4WYOQBrOmMt wQ6AOw32GQisIC1TsGuFRMLmkoV8cEfV/rdQPgDqghjjdW7JoBKeYmw4ADr4zSeBcKWqaZAwQk6 BVg== X-Google-Smtp-Source: AGHT+IF3YmDiUVLol3Ma2dGjY66h66Myp8jul3JHp2eJRacVDXua9zfCDa1EBBpN/JLALWFl8Uus4BKOxZ8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1b8d:b0:dc2:331e:48b9 with SMTP id ei13-20020a0569021b8d00b00dc2331e48b9mr313ybb.12.1706657100630; Tue, 30 Jan 2024 15:25:00 -0800 (PST) Date: Tue, 30 Jan 2024 15:24:58 -0800 In-Reply-To: <20240109141121.1619463-2-vkuznets@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240109141121.1619463-1-vkuznets@redhat.com> <20240109141121.1619463-2-vkuznets@redhat.com> Message-ID: Subject: Re: [PATCH 1/5] KVM: selftests: Generalize check_clocksource() from kvm_clock_test From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Oliver Upton , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Jan 09, 2024, Vitaly Kuznetsov wrote: > +bool sys_clocksource_is_tsc(void) > +{ > + char *clk_name = sys_get_cur_clocksource(); > + bool ret = false; > + > + if (!strcmp(clk_name, "tsc\n")) > + ret = true; This can more simply be: bool ret = !strcmp(clk_name, "tsc\n"); and then bool ret = !strcmp(clk_name, "tsc\n") || !strcmp(clk_name, "hyperv_clocksource_tsc_page\n"); when the Hyper-V variant comes along. I'll fixup when applying unless you violently disagree.