From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34A72C1BE for ; Thu, 1 Feb 2024 17:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706806898; cv=none; b=frATU/5HpKeqimS29dsf5zSNw6YGAKgZVFSuqB6ZJcwmAmGybzELSwbmlXRzAXGcv/cDSVyyqTtks8+LaLbpTsA06FN7ucHXe7YKY8wSKz3jSs3Gr3MjXHLv4pM9KsaT8Ja1oCtG3HguNBg/uT4grnthw5c9JHor1DBm5oy9Hx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706806898; c=relaxed/simple; bh=404+oMX5DYoQ8uCTQtK/PDwUpYsIJ9z/UK9iHiXZ+Uc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ko8N5bq6DF2BHS7OrXeK40bULRwbZQOCKN+2XiuthQJr76Oh6WPTxWMcp+vC8D35VL/E3f0RzaNENM4rYZClqoFz2Yua4SiQrSMv1aJhZtRYb4rdfYYRxwYVE/TgvEauSQsr+ucF+K+gguE5pKyQQPy1G1Xt5MVDG4Q9pZVqj84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EWI8er/J; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EWI8er/J" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60403a678f2so19800417b3.3 for ; Thu, 01 Feb 2024 09:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706806896; x=1707411696; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bt+l8LQwp/+KP1L4+VoJP1PtxEUI5oG7XATKE+2Azog=; b=EWI8er/JBe7rioihydfyqna4vpQ7FBJYw/TVMft6Dml47NY0+WyYFV1aJpNu8kUcuZ 2+Ire465LK1OluzILwWwT7GXvU5SN0xMw/xnMCYsBS4ZpRZkGeb/FJhY8mYYOVJga4Al ZV1rGY5xpzU7Per3zdpCiTbShfDm3M3vjRrfuI9Yrwbvg8M410o2o2O6Df2SoxLJTn/1 z8VAPJU3gx6HWsTxqrFAqpwdOI+I8kwPXJpf0nDeEvZxnwhAs3mT67VAOXx5i/GRluTB X9wBMWqTdokMH6BQcbHgDDZDmC3lSkIeMa1tX5/Kt8eaNr7cZ8fwU52lqleqyXut3qJn 8p2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706806896; x=1707411696; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bt+l8LQwp/+KP1L4+VoJP1PtxEUI5oG7XATKE+2Azog=; b=j9qkAY+DBM/QMwtWGLLQAJW+hlSzU743BkgQikETTjP8AV6EJQsSGMsXf67JU1oqAh Xsr9u7QITFEsoHOCVXxQhb9csyBjgyFrLBolqHJh1wTLxv7khSH9NqFtMtBG4BjMC0xL X02Upv7HZ1CzKDSXdkVx4RpoMF9Qa2cF1cQnNjcbi5PQg45C1dfNsfjOhmjHPfTMJIO7 ZmdI7ZttDmojMheMoHqKioMA9ZMpksv08lHknBM/mzmSIQzJnzW6+gs8MhaT0T1WIyOa UG/u9mem8nOpQrdnycEyHm44PHjWHaR6wOCWEdxl4cp3blynq+8sA/HQ9wHYaEYEhU6b ytLg== X-Gm-Message-State: AOJu0YzekR8e7iEsd73Bzk8y6s+Sw6m8kEjnxjinXBM3CM/H5QUxqz37 bx7MfTttP6J84/xF0P25Br29zXvq/yo4AhetEmZ932alAB3bb7oAcerjgW5cMGaRLoXf7W0vGbT tujNXGbONnW94OkaMtGIodvRtmMi62FMz7kTExRbRkv1LnbypmPfDBRzSnC137/Gy4tTYHklmOi SwE9FS+GwMlvUW2H/d0hgogOfhdnEY X-Google-Smtp-Source: AGHT+IHn1/T64LldLBtNyUreN5Tq5xOAFLu/0q2+MM560sHJ2yM3qHilJxeJHjNw4vn+JjyLZFoNsJkfZcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:4c0d:0:b0:5fb:7e5b:b87f with SMTP id z13-20020a814c0d000000b005fb7e5bb87fmr1199825ywa.1.1706806895945; Thu, 01 Feb 2024 09:01:35 -0800 (PST) Date: Thu, 1 Feb 2024 09:01:34 -0800 In-Reply-To: <170666266419.3861766.8799090958259831473.b4-ty@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240111135901.1785096-1-vkuznets@redhat.com> <170666266419.3861766.8799090958259831473.b4-ty@google.com> Message-ID: Subject: Re: [PATCH] KVM: selftests: Compare wall time from xen shinfo against KVM_GET_CLOCK From: Sean Christopherson To: kvm@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov Cc: David Woodhouse , Jan Richter , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Jan 30, 2024, Sean Christopherson wrote: > On Thu, 11 Jan 2024 14:59:01 +0100, Vitaly Kuznetsov wrote: > > xen_shinfo_test is observed to be flaky failing sporadically with > > "VM time too old". With min_ts/max_ts debug print added: > > > > Wall clock (v 3269818) 1704906491.986255664 > > Time info 1: v 1282712 tsc 33530585736 time 14014430025 mul 3587552223 shift 4294967295 flags 1 > > Time info 2: v 1282712 tsc 33530585736 time 14014430025 mul 3587552223 shift 4294967295 flags 1 > > min_ts: 1704906491.986312153 > > max_ts: 1704906506.001006963 > > ==== Test Assertion Failure ==== > > x86_64/xen_shinfo_test.c:1003: cmp_timespec(&min_ts, &vm_ts) <= 0 > > pid=32724 tid=32724 errno=4 - Interrupted system call > > 1 0x00000000004030ad: main at xen_shinfo_test.c:1003 > > 2 0x00007fca6b23feaf: ?? ??:0 > > 3 0x00007fca6b23ff5f: ?? ??:0 > > 4 0x0000000000405e04: _start at ??:? > > VM time too old > > > > [...] > > Applied to kvm-x86 selftests. David, please holler if you disagree with > any of the changes. They look sane to me, but clock stuff ain't my forte. > > Thanks! > > [1/1] KVM: selftests: Compare wall time from xen shinfo against KVM_GET_CLOCK > https://github.com/kvm-x86/linux/commit/a0868e7c5575 FYI, I've dropped this as it looks like there will be a new version.