From: Sean Christopherson <seanjc@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Stevens <stevensd@chromium.org>,
Yu Zhang <yu.c.zhang@linux.intel.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
Zhi Wang <zhi.wang.linux@gmail.com>,
kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v9 0/6] KVM: allow mapping non-refcounted pages
Date: Mon, 5 Feb 2024 19:29:32 -0800 [thread overview]
Message-ID: <ZcGnnIJNPG-nGAND@google.com> (raw)
In-Reply-To: <ZRpiXsm7X6BFAU/y@infradead.org>
On Sun, Oct 01, 2023, Christoph Hellwig wrote:
> On Fri, Sep 29, 2023 at 09:06:34AM -0700, Sean Christopherson wrote:
> > With the cleanups done, playing nice with non-refcounted paged instead of outright
> > rejecting them is a wash in terms of lines of code, complexity, and ongoing
> > maintenance cost.
>
> I tend to strongly disagree with that, though. We can't just let these
> non-refcounted pages spread everywhere and instead need to fix their
> usage.
Sorry for the horrifically slow reply.
Is there a middle ground somewhere between allowing this willy nilly, and tainting
the kernel? I too would love to get the TTM stuff fixed up, but every time I look
at that code I am less and less confident that it will happen anytime soon. It's
not even clear to me what all code needs to be touched.
In other words, is there a way we can unblock David and friends, while still
providing a forcing function of some kind to motivate/heckle the TTM (or whatever
is making the allocations) to change?
next prev parent reply other threads:[~2024-02-06 3:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 2:16 [PATCH v9 0/6] KVM: allow mapping non-refcounted pages David Stevens
2023-09-11 2:16 ` [PATCH v9 1/6] KVM: Assert that a page's refcount is elevated when marking accessed/dirty David Stevens
2023-09-11 2:16 ` [PATCH v9 2/6] KVM: mmu: Introduce __kvm_follow_pfn function David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 1:25 ` Sean Christopherson
2024-02-06 3:16 ` Sean Christopherson
2024-02-13 3:27 ` Sean Christopherson
2024-02-13 3:44 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 3/6] KVM: mmu: Improve handling of non-refcounted pfns David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 2:54 ` Sean Christopherson
2024-02-13 3:44 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 4/6] KVM: Migrate kvm_vcpu_map to __kvm_follow_pfn David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2023-09-11 2:16 ` [PATCH v9 5/6] KVM: x86: Migrate " David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2023-10-03 20:58 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 6/6] KVM: x86/mmu: Handle non-refcounted pages David Stevens
2023-09-18 9:53 ` Dmitry Osipenko
2023-09-19 2:25 ` David Stevens
2023-09-30 13:34 ` Dmitry Osipenko
2023-09-18 9:58 ` Dmitry Osipenko
2023-09-18 11:19 ` Dmitry Osipenko
2023-09-19 2:59 ` David Stevens
2023-09-21 20:06 ` Dmitry Osipenko
2023-09-30 13:34 ` Dmitry Osipenko
2023-09-19 2:31 ` David Stevens
2023-09-21 20:04 ` Dmitry Osipenko
2024-02-06 3:02 ` Sean Christopherson
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 3:23 ` Sean Christopherson
2023-09-29 5:19 ` [PATCH v9 0/6] KVM: allow mapping " Christoph Hellwig
2023-09-29 16:06 ` Sean Christopherson
2023-10-02 6:25 ` Christoph Hellwig
2024-02-06 3:29 ` Sean Christopherson [this message]
2023-10-31 4:30 ` David Stevens
2023-10-31 14:30 ` Sean Christopherson
2023-12-12 1:59 ` David Stevens
2023-12-20 1:37 ` Sean Christopherson
2024-02-06 3:30 ` Sean Christopherson
2024-02-13 3:39 ` Sean Christopherson
2024-02-21 6:05 ` David Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcGnnIJNPG-nGAND@google.com \
--to=seanjc@google.com \
--cc=hch@infradead.org \
--cc=isaku.yamahata@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=stevensd@chromium.org \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox