From: Sean Christopherson <seanjc@google.com>
To: Eric Auger <eauger@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shaoqin Huang <shahuang@redhat.com>
Subject: Re: [PATCH] KVM: selftests: Fix a semaphore imbalance in the dirty ring logging test
Date: Wed, 7 Feb 2024 06:44:25 -0800 [thread overview]
Message-ID: <ZcOXSZ2OPL5WCcRM@google.com> (raw)
In-Reply-To: <6fdbeed0-980e-4371-a448-0c215c4bc48e@redhat.com>
On Wed, Feb 07, 2024, Eric Auger wrote:
> Hi Sean,
>
> On 2/6/24 22:36, Sean Christopherson wrote:
> > On Fri, 02 Feb 2024 15:18:31 -0800, Sean Christopherson wrote:
> >> When finishing the final iteration of dirty_log_test testcase, set
> >> host_quit _before_ the final "continue" so that the vCPU worker doesn't
> >> run an extra iteration, and delete the hack-a-fix of an extra "continue"
> >> from the dirty ring testcase. This fixes a bug where the extra post to
> >> sem_vcpu_cont may not be consumed, which results in failures in subsequent
> >> runs of the testcases. The bug likely was missed during development as
> >> x86 supports only a single "guest mode", i.e. there aren't any subsequent
> >> testcases after the dirty ring test, because for_each_guest_mode() only
> >> runs a single iteration.
> >>
> >> [...]
> >
> > Applied to kvm-x86 selftests, thanks!
> Do you plan to send this branch to Paolo for v6.8?
That wasn't my initial plan, but looking at what's in there, the only thing that
isn't a fix is Andrew's series to remove redundant newlines. So yeah, I'll send
this along for 6.8.
next prev parent reply other threads:[~2024-02-07 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 23:18 [PATCH] KVM: selftests: Fix a semaphore imbalance in the dirty ring logging test Sean Christopherson
2024-02-04 4:22 ` Shaoqin Huang
2024-02-06 6:02 ` Dongli Zhang
2024-02-06 8:54 ` Peter Xu
2024-02-06 21:36 ` Sean Christopherson
2024-02-07 12:56 ` Eric Auger
2024-02-07 14:44 ` Sean Christopherson [this message]
2024-02-07 15:43 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcOXSZ2OPL5WCcRM@google.com \
--to=seanjc@google.com \
--cc=eauger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=shahuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox