From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDAC10A0F for ; Wed, 14 Feb 2024 01:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707873917; cv=none; b=JbwWEZb2VX/TW15xGY6rRp+Az0S79+/mFphRWpiSWQruWdrRpLyYN+9WBFifBz1JQqh0fPaTnTTQQ0yDgsJsqt6WzlirUlJoxETiCNF5l3+XjL64fSGhtYiTSCWCm7FkyscH93elVVTOvgt0zY+QeiaWlMOQ/iCCxJaewdD5zWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707873917; c=relaxed/simple; bh=kBmFiiY9jhtAVicGFCw6oDxKBEb/1sMPTS6zBLvauYw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VptCw0icvOV0CSlFVX/VxHCKJhzffE+ELa2NNj3GoBHavu04ypFMQ/Y5oEBG14H8pd1CE5/gEd/8yRiwS0A9QWQNC8+2TLlpklUMIzNBDfZ0jcL9AGKh1tkENkPVjzomwJomqeoOlNLd1SHEVEgLDv8UeuXKYMWso9K96p0H6pQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aryhbU8F; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aryhbU8F" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-6e0a461e125so3146924b3a.3 for ; Tue, 13 Feb 2024 17:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707873915; x=1708478715; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3lhldJgYh3LnuFXh1KrZsXRF/R8L81Sit87YMrma8b0=; b=aryhbU8F+xkHsBm5xqeHgGhJ73EWPKyEjKFfBOLwn9oFA5Q6ICgoey3oyLrnrNn1Ba xKN8+CTgjSJygskcaBT4iloTlI9NR4aHOlzc7cST1gMlm0hkRtF3qJ15+OsCijXe3iqO WT1J9QLbBKwHLjDXMzpI6/W6iVZwlATST5dT+z2CRmem1wW+rFDzt7ofFkRx1IEw6dnn /fDa1jHEwnMczKXIvkR1P+Zkkxawmvk3TAZDK95I80NNTiSb+6KbqZuCSzLF0EZV+GvJ PnxoCVvXpmFgpEwFl+8yltfZYstT6gfzOGB+2Dqho0vtX6LXq1FsikO5It9aoimJtSVS wxHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707873915; x=1708478715; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3lhldJgYh3LnuFXh1KrZsXRF/R8L81Sit87YMrma8b0=; b=mf1JN1KUIo9NFnHthiHvxUu8w9ecO82V8JZ4BSSkhMckf7pAIKhOa0noB51W5mCD6x hArdi0UTukyC0BYUp4r6fqEH1zSmtHoMDle5tGOiUVlKCUcu28kZdlh0oQncaSAwc8Dm XovKlfqOI/W6d4KKjLJF0tGiA8BVqye1KxgXKhf30gB9rSZaq3gyp9r+ni82rXluqHSm E1TY1MSfFdyzEKul+7iofYPy6pZtINH8wSFXHBS1qJC9TjlLNN8+QPvR88fq6zFkRcJH zKlFW4jOBp/LaS8n9MRBqzKlVsExPe6dO/CNzeBuhMWwX6QoUWHwedcqOWc0468e0PHo mJ8A== X-Forwarded-Encrypted: i=1; AJvYcCU24EGufzeVHjjKqvAYfupTMBde1nOykRZ7MYyOpTgsuShLehziF7HLCW5Ml+hg/w/sWjJKAlfbHWE1bNVTrHfGDjo/ X-Gm-Message-State: AOJu0Yy8u3D4WhUYFOz6pZvzkvSybhEluSqGkymrk/0HJp6sBTksgaSb CwmVyxmKFiNlg1brfUGN+qzjj9VHA5iWCoDD5xlN8UtBnIdum5w2imxGq8Xd9+j9xQFPVGz3kya Njw== X-Google-Smtp-Source: AGHT+IFqV2lSphRIVe9wjsewmJ//Lgp0BElNWtsrnt2MAbcVpRrpiic5wlkUy+bWcOjElus+LklBUavnZlg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:3d4e:b0:6e0:57f1:688d with SMTP id lp14-20020a056a003d4e00b006e057f1688dmr28365pfb.2.1707873915478; Tue, 13 Feb 2024 17:25:15 -0800 (PST) Date: Tue, 13 Feb 2024 17:25:14 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240206182032.1596-1-xin3.li@intel.com> Message-ID: Subject: Re: [PATCH v5 1/2] KVM: VMX: Cleanup VMX basic information defines and usages From: Sean Christopherson To: Xin3 Li Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , Weijiang Yang , Kai Huang Content-Type: text/plain; charset="us-ascii" On Wed, Feb 14, 2024, Xin3 Li wrote: > > VMX_EPT_PAGE_WALK_4_BIT))) > > return false; > > break; > > default: > > return false; > > } > > > > I see your point here. But "#define VMX_EPTP_MT_WB 0x6ull" seems to define > its own memory type 0x6. I think what we want is: > > /* in a pat/mtrr header */ > #define MEM_TYPE_WB 0x6 > > /* vmx.h */ > #define VMX_EPTP_MT_WB MEM_TYPE_WB > > if it's not regarded as another layer of indirect. Heh, yep, I already had this: /* The EPTP memtype is encoded in bits 2:0, i.e. doesn't need to be shifted. */ #define VMX_EPTP_MT_MASK 0x7ull #define VMX_EPTP_MT_WB X86_MEMTYPE_WB #define VMX_EPTP_MT_UC X86_MEMTYPE_UC