From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 693B970024 for ; Wed, 28 Feb 2024 21:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709155194; cv=none; b=blWTz/B6XhJXUQFhtnSguIiP97UA2TlFDSQpLqcw+IKCxYnwWSK0eebOBGNs1OeoPUH4vqvwCY8oF+zjkV15vtM2e363mkumUnW7C5+XRS+0ig48a3JkSaGAYGX17cbr4McZfTvsCrT88R1QLth+iHkDZwDd7xbeCX4Z1Mc1OCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709155194; c=relaxed/simple; bh=gk/MrBtcV7Nj4M6X2sQOVcKzwLMPmaE9N2JN751XURU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gQr11M0RvHstGLgELj+lg3BuWb801rq/vP1MzZZLPnaVANcr/74A486dRTo8JsZroKL19XDJ93VYnzD4m4GHjGgsuhBg4G7ZBqqYbcuegWM03c3uPPWVHVLOIZ1c0/ivtOxbvVOlDquvmymC008YsmP5ZxSf2cEFQE+9DklY5Ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=poRPXhfs; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="poRPXhfs" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60966f363c1so1477577b3.3 for ; Wed, 28 Feb 2024 13:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709155190; x=1709759990; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=I3lMvE57lAGMOn/5i5GUfHlWgJVlKCqOgZHHFIXT5YI=; b=poRPXhfsYkCniLxu2SKdSpdTc8kxYQFx268+jR6EGsyEEsUNkBSLHbI8qy4ZXOAELO Ygn0BdGKwB3A70aIzf1JPMv7vBbEFE8Re1J5rwL+kfhdMazmI/71c+ySjWteu/kEzZED dEmyXtOUe3gve0NgqXtGvDTppaVDyEv+r/DMj49nqVo6+lMCLonzFiL5vSQ2njXdSLuh yYd3bOsrd4eDJhAeSAHjtMX3qXkrVU1XlCGWvEvnBTzzcNiH46/KNb6R5KJSMSyP2pJE dyglx+6TLSZ/0mRg2ZnavTNyvDbv+0RWf3CI3fy5CmiwQihdR/PeI89ajk9MpWIcona9 Z4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709155190; x=1709759990; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=I3lMvE57lAGMOn/5i5GUfHlWgJVlKCqOgZHHFIXT5YI=; b=fPXEzDHpM+7sTaZNbeeZtl53OL4aDJ2WGDv48h/74ZGu8hqUI7ljgWJAJ+6D202KGV geqk96dal1lasDXe8XrBKU2uloKV8at7DwInwShm3lh4FFXrLg6I76pns0GLEsdKWNjG orb8YnIcIxOBp24oGqJfbavmwse7NJCyW/XsHkcQZQSzIn6IwPYleQ8yJTS+SZ80AlbG M26cod0v2TBZr3Yl7vNCMf7AZ86smuS5gZM2MK5z0hZx8dJD44JvBto0grLxLjDAkRBp Q3wLSWAy+qk9viJ20A9DF35j3epqCuLOro85qk918ow29P0VWaAmTlCnvQkP+o1Ff323 yZwQ== X-Forwarded-Encrypted: i=1; AJvYcCWYq2BAGh1TriWqNBNz8DaLRQ+CZSTmueZc7MwqPEcaqQQ6pLGKdrMkugsPn26tRqVuzIPExxf0Sdect8Yi1/U6zmvE X-Gm-Message-State: AOJu0Yz0QwzN7s6Iw1k6ZecpQ7Te6YuJ6UEU+z9mbwHyxVgz70bqpEmx VuiEGKal6OEy3XwiRchtRU9hYBcU6NeWsRO83b6NdlVdKJSqzdLzSCEgV/cWNTKReVjKZKQblxu hOg== X-Google-Smtp-Source: AGHT+IGIb2EDaA1Xfc5xFJEWOVFhVtRT96S9AFF70n2hacpd3aAGkhz27VZdHFJQY6yEoiJnM3glwUpknsM= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:338b:b0:609:22ea:f95e with SMTP id fl11-20020a05690c338b00b0060922eaf95emr59391ywb.4.1709155190409; Wed, 28 Feb 2024 13:19:50 -0800 (PST) Date: Wed, 28 Feb 2024 13:19:48 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240208204844.119326-1-thuth@redhat.com> <20240208204844.119326-4-thuth@redhat.com> <501ac94d-11ab-4765-a25d-75013c021be6@sirena.org.uk> Message-ID: Subject: Re: [PATCH v3 3/8] KVM: selftests: Move setting a vCPU's entry point to a dedicated API From: Sean Christopherson To: Mark Brown Cc: Thomas Huth , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Jones , Marc Zyngier , Oliver Upton , Aishwarya TCV Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Oliver and/or Marc, question for y'all towards the bottom. On Wed, Feb 28, 2024, Sean Christopherson wrote: > On Wed, Feb 28, 2024, Mark Brown wrote: > > On Thu, Feb 08, 2024 at 09:48:39PM +0100, Thomas Huth wrote: > > > From: Sean Christopherson > > >=20 > > > Extract the code to set a vCPU's entry point out of vm_arch_vcpu_add(= ) and > > > into a new API, vcpu_arch_set_entry_point(). Providing a separate AP= I > > > will allow creating a KVM selftests hardness that can handle tests th= at > > > use different entry points for sub-tests, whereas *requiring* the ent= ry > > > point to be specified at vCPU creation makes it difficult to create a > > > generic harness, e.g. the boilerplate setup/teardown can't easily cre= ate > > > and destroy the VM and vCPUs. > >=20 > > With today's -next I'm seeing most of the KVM selftests failing on an > > arm64 defconfig with: > >=20 > > # =3D=3D=3D=3D Test Assertion Failure =3D=3D=3D=3D > > # include/kvm_util_base.h:677: !ret > > # pid=3D735 tid=3D735 errno=3D9 - Bad file descriptor > > # 1 0x0000000000410937: vcpu_set_reg at kvm_util_base.h:677 (discr= iminator 4) > > # 2 (inlined by) vcpu_arch_set_entry_point at processor.c:370 (di= scriminator 4) > > # 3 0x0000000000407bab: vm_vcpu_add at kvm_util_base.h:981 > > # 4 (inlined by) __vm_create_with_vcpus at kvm_util.c:419 > > # 5 (inlined by) __vm_create_shape_with_one_vcpu at kvm_util.c:43= 2 > > # 6 0x000000000040187b: __vm_create_with_one_vcpu at kvm_util_base= .h:892 > > # 7 (inlined by) vm_create_with_one_vcpu at kvm_util_base.h:899 > > # 8 (inlined by) main at aarch32_id_regs.c:158 > > # 9 0x0000007fbcbe6dc3: ?? ??:0 > > # 10 0x0000007fbcbe6e97: ?? ??:0 > > # 11 0x0000000000401f2f: _start at ??:? > > # KVM_SET_ONE_REG failed, rc: -1 errno: 9 (Bad file descriptor) > >=20 > > and a bisect pointed to this commit which does look plausibly relevant. > >=20 > > Note that while this was bisected with plain arm64 defconfig and the KV= M > > selftests fragment was not enabled, but enabling the KVM fragment gave > > the same result as would be expected based on the options enabled by th= e > > fragment. We're also seeing an alternative failure pattern where the > > tests segfault when run in a different environment, I'm also tracking > > that down but I suspect these are the same issue. >=20 > Gah, my bad, I should have at least tested on ARM since I have easy acces= s to > such hardware. If I can't figure out what's going wrong in the next few = hours, > I'll drop this series and we can try again for 6.10. >=20 > Sorry :-/ /facepalm The inner helper doesn't return the vCPU, and by dumb (bad) luck, selftests= end up trying to use fd=3D0. diff --git a/tools/testing/selftests/kvm/lib/aarch64/processor.c b/tools/te= sting/selftests/kvm/lib/aarch64/processor.c index ed4ab29f4fad..a9eb17295be4 100644 --- a/tools/testing/selftests/kvm/lib/aarch64/processor.c +++ b/tools/testing/selftests/kvm/lib/aarch64/processor.c @@ -386,6 +386,7 @@ static struct kvm_vcpu *__aarch64_vcpu_add(struct kvm_v= m *vm, uint32_t vcpu_id, aarch64_vcpu_setup(vcpu, init); =20 vcpu_set_reg(vcpu, ARM64_CORE_REG(sp_el1), stack_vaddr + stack_size= ); + return vcpu; } =20 struct kvm_vcpu *aarch64_vcpu_add(struct kvm_vm *vm, uint32_t vcpu_id, I'll squash the above and force push. In my defense, I would have caught this when build-testing, as the compiler= does warn... lib/aarch64/processor.c -o /usr/local/google/home/seanjc/go/src/kernel.or= g/nox/tools/testing/selftests/kvm/lib/aarch64/processor.o lib/aarch64/processor.c: In function =E2=80=98__aarch64_vcpu_add=E2=80=99= : lib/aarch64/processor.c:389:1: warning: no return statement in function r= eturning non-void [-Wreturn-type] 389 | } | ^ At top level: cc1: note: unrecognized command-line option =E2=80=98-Wno-gnu-variable-si= zed-type-not-at-end=E2=80=99 may have been intended to silence earlier diag= nostics but due to a different issue that is fixed in the kvm-arm tree[*], but not = in mine, I built without -Werror and didn't see the new warn in the sea of GUEST_PRI= NTF warnings. Ugh, and I still can't enable -Werror, because there are unused functions i= n aarch64/vpmu_counter_access.c aarch64/vpmu_counter_access.c:96:20: error: unused function 'enable_count= er' [-Werror,-Wunused-function] static inline void enable_counter(int idx) ^ aarch64/vpmu_counter_access.c:104:20: error: unused function 'disable_cou= nter' [-Werror,-Wunused-function] static inline void disable_counter(int idx) ^ 2 errors generated. make: *** [Makefile:278: /usr/local/google/home/seanjc/go/src/kernel.org/= nox/tools/testing/selftests/kvm/aarch64/vpmu_counter_access.o] Error 1 make: *** Waiting for unfinished jobs.... Commit 49f31cff9c533d264659356b90445023b04e10fb failed to build with 'mak= e-clang make-arm make -j128'. Oliver/Marc, any thoughts on how you want to fix the unused function warnin= gs? As evidenced by this goof, being able to compile with -Werror is super help= ful. And another question: is there any reason to not force -Werror for selftest= s? [*] https://lore.kernel.org/all/20240202234603.366925-1-seanjc@google.com