Re: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test

Sean Christopherson
2024-03-14T15:06:23Z

On Thu, Mar 14, 2024, Manali Shukla wrote:
> >> +#define VINTR_VECTOR 0x30
> >> +#define NUM_ITERATIONS 100000
> >
> > What's the runtime? If it's less than a second, then whatever, but if it's at
> > all longer than that, then I'd prefer to use a lower default and make this user-
> > configurable.
>
> It takes ~34s to run this test.

LOL, yeah, no. That's 33+ seconds of wasted time. From a *KVM* perspective, this
is quite binary: either KVM intercepts HLT or it doesn't. Any timing bugs would
be purely CPU bugs.

Please adjust this to have the default runtime <1 second. If you feel strongly
about the need for a long-running test, feel free to add a command line option
to control the number of iterations.