From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822E86FE08 for ; Thu, 14 Mar 2024 15:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710428784; cv=none; b=th1jNjjxMD0y4owJ5DQOGsPWapQih+++HqAjRtV7nJXMcqtLSfEt1zik6M5JlSqOECeLSjCcuxbFe2rhKsgSbNM82++1y1wr2RyZ22/U5Zb7uJ/NXitW0gMSKJGFDn9XoVWUwk7+KhQSh3rM7w6/yC9aXO0fKZlKkL+hd26reSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710428784; c=relaxed/simple; bh=qAF098DlT+6JM10nDKjNTf3V6FncHjyrZW3EwN8ISP0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=A6OclGd9IQnpyBiEgkH3qCDwByA+3JDaHLgR1tWTH+uJZ36GfEikHi6OzFA4AQH6QcxUDSD6R5Lo2bFOoeYD5FGeEW5Ek5auefMDeB7D+0SRGgXOUbPpDf04exYK/WoUxdhzpYaBNk7OfYvbFq0DRehJLv6XzTAxHLYaeu5WdLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=y78bywA4; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="y78bywA4" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dbe9e13775aso1604605276.1 for ; Thu, 14 Mar 2024 08:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1710428782; x=1711033582; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6sHqI9hK8jeRVoeWIaG19PRjQ47Chrrt5p/7K3x2jvg=; b=y78bywA4kP1dXfRwd6QZGbKseNx07BaWLN7NpgvXPEc7TolnPbu+AGurVRJ89jEJv+ ezd6+mLLugczmiaAVi79SmFwn0JwzjAKg4lL/TQvc0JZ6KwnH9fLpGJtnR41C6+adgK6 EEbho3rvLl9nI168yXo9Q0oPwUDBXXE/njID7+XQnw16uG9W68akYqZw/yNhlaJBRKPa oaL5qmQB+agKGRVnClHD/rs3pJMQvV5yeKtlGAXVvw2Pc1662i3ZOiMTgBAXKn6euak6 UEPYi3rVy76EaIP+KIGOhO0KGbiYQxWLJt/J3njX1FgfZxG4YYqu2/X7WQZlBPbg97jw CG7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710428782; x=1711033582; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6sHqI9hK8jeRVoeWIaG19PRjQ47Chrrt5p/7K3x2jvg=; b=eNUNiZivQWMowQEwUZJLqxXSIEfFOCT2rprYh/MQoyKNh8+dWVF0USyfj4J/Fuk0rK Gqa56sKj+h/ym9QqNSK0ewU0S2tUC/OJZhCogZXgWZftCoblbPbpjohU2A9w2NZdz33K fKLgN1jDnQs5OJcOsAgKEookrNc5aEVCutkNJ/loj1MCvvKzsCIoDDlvTpaWB0kPS5iw SPgpCBFBLakthIjg4Ut0D/utDj1M0dHbETQu8OXXnu4hqIYnmKzO2JM6jhMsBuhOhPV9 ZfZXmzWggf9d3tpbDc1LRn/O2Xnu5AjZU+fBTeANBRtF2030eaUELhOkcV1mf36TgZnL BD/w== X-Gm-Message-State: AOJu0YyV556R4cH+aAtaxHAyoImiGFM73h09Kru6cV2irs0SxQ7UcCQS V4N+B1W+vbuTVrh97pkCiFCgFZxgkrB/U0TJZcgePdkyD0EseheZRbShFZii/b9Et6acvULk279 MTw== X-Google-Smtp-Source: AGHT+IGIHnvNXsJY+h0Oj+c1Jth/LNRun/lFwuFNkYAKkEBK1aH8bI0QN3CxQRqDBwbgmhCUDXK2Ny6/WBg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:2510:b0:dc6:ff54:249f with SMTP id dt16-20020a056902251000b00dc6ff54249fmr543415ybb.8.1710428782630; Thu, 14 Mar 2024 08:06:22 -0700 (PDT) Date: Thu, 14 Mar 2024 08:06:21 -0700 In-Reply-To: <075ff472-67c7-4cb1-a344-9c1066821eb4@amd.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240307054623.13632-1-manali.shukla@amd.com> <20240307054623.13632-6-manali.shukla@amd.com> <075ff472-67c7-4cb1-a344-9c1066821eb4@amd.com> Message-ID: Subject: Re: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test From: Sean Christopherson To: Manali Shukla Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, nikunj@amd.com, thomas.lendacky@amd.com, vkuznets@redhat.com, bp@alien8.de Content-Type: text/plain; charset="us-ascii" On Thu, Mar 14, 2024, Manali Shukla wrote: > >> +#define VINTR_VECTOR 0x30 > >> +#define NUM_ITERATIONS 100000 > > > > What's the runtime? If it's less than a second, then whatever, but if it's at > > all longer than that, then I'd prefer to use a lower default and make this user- > > configurable. > > It takes ~34s to run this test. LOL, yeah, no. That's 33+ seconds of wasted time. From a *KVM* perspective, this is quite binary: either KVM intercepts HLT or it doesn't. Any timing bugs would be purely CPU bugs. Please adjust this to have the default runtime <1 second. If you feel strongly about the need for a long-running test, feel free to add a command line option to control the number of iterations.