From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A6333DAC14 for ; Wed, 27 Mar 2024 05:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711517891; cv=none; b=U2cSQv5pDrXAJJkD8OTu7219AzUDxoPtD16QKhNcMpWXYwGYGdgjZ7idndbzd02EUB8CyT2O0QpD/nrk4BpGVBEgaGE/8kIdwmLeOElOL5CCo4hKZUcROGzYY2cVHzC0Q4eEp5Dm/t6LmJfn9hp1e459k51Y+l/HIukWTbKgmaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711517891; c=relaxed/simple; bh=jxc+ifoFr0vgBSifpzL8V8mividmrbHl9bnUpbSaOyw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pU0LbEc7d9mTFk29KlBKyAMXQnNdNdpyJyAVjw2VXiajx/aih3u1hcVLN1TF1zlm5hm1/UANhFaMoXBPQeT639/i3sacC5Ej8K2hOK8kH6T1/Mz12JVIsHf0vTQnnAPye3A8usGaxFDXlwn9dlhNvoE+ZLqTCgwIMrL3VpiskdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oa/DEGd0; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oa/DEGd0" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1e0fa980d55so11756165ad.3 for ; Tue, 26 Mar 2024 22:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711517889; x=1712122689; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p+fNf8kwFz9hjq+tSfSz7ViPMcYhwL+6JOaYs7sM0+E=; b=oa/DEGd0yovKgc5TNRYErhX7KbrtZ20H/npE9XkgpH+0jQXBC1fEi6OrVpCXbuHimm spy2+Alg54Uquex7Xf6npavkiS4HsrJpgT+nhVge2H99YubGN00kBVsmjTkR1VhwkNRa ordcTCvz907yrvC50ib+uHa+9it8cVUdWs55AIgam28imOyVOK7+7C86d/Tp207AYujg zSArMWlVHMgcZq5E8PfIeHKb/MQTIsYyfC5/MVetG7IoLSRck4LrkLb7oqNdVoj9LIEO L8cbFfkYlLb9D7ZoANYb6/b44ZQr0fZdfuZoIIfaOLD6VSZ9iQZPr20QjPNHxSZI8ecu ZyJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711517889; x=1712122689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p+fNf8kwFz9hjq+tSfSz7ViPMcYhwL+6JOaYs7sM0+E=; b=eZzmpqIxdKdnHgTTI7HmVdk4ZqtfORgHVGt/LNw0I7HXcG5U6/Rf3ThFATNlZ6PgZC solBEw3x7pKu1CRntUzZEU97gY6a/SaylpVYnGytc6jQGwtNGvtcapNIYdhP2dFRr+oE GvCQ/pPBuyjPbQHoAHS/SBvN209qOq1FxwYKDRf8HPWfb0mYovajoDMoq/fduH5YaCyT BWjipOkjlGAcd/fZ/Xye4T/riXY7a8h2iimq2Vt3BOYl+9JywXBlNGQysc8fe09ObtDJ oo5LVb4u9UNabzmJBq720fYWHL6eiIjhCLyclce+oG8OEYlknFVPU5Rz7iUyz8LdiIp3 3hxQ== X-Forwarded-Encrypted: i=1; AJvYcCXVvwK/rhWxjBbA93DRinti6wppdGnAoySaQ33V5WQAAzF29+Om2zhFn4VgMY0tQOc+eQXs6ZYIrTYez1QiPQlv2JRO X-Gm-Message-State: AOJu0YwoEKDZLAFUNFZVfmfGKiE9Qs8IZawFU5VPtS9NPANBK5ElAY1U AiEDwInXMIrkS1770rwf9Q0eD2dFAntcknQx88xIhI1mhDiyjL+GYz625v/nWw== X-Google-Smtp-Source: AGHT+IFfDJJu8eU5vpeHwdnNhSO9hlVbXO/frk+1YOkjU00bY6YbyW2aBR6BF2q3X4HfdBGyzFXKuQ== X-Received: by 2002:a17:90a:eb04:b0:29d:dbaf:bd77 with SMTP id j4-20020a17090aeb0400b0029ddbafbd77mr2908734pjz.43.1711517889217; Tue, 26 Mar 2024 22:38:09 -0700 (PDT) Received: from google.com (60.89.247.35.bc.googleusercontent.com. [35.247.89.60]) by smtp.gmail.com with ESMTPSA id pd15-20020a17090b1dcf00b0029fc4b3596bsm662952pjb.7.2024.03.26.22.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 22:38:08 -0700 (PDT) Date: Wed, 27 Mar 2024 05:38:05 +0000 From: Mingwei Zhang To: Dapeng Mi Cc: Sean Christopherson , Paolo Bonzini , Jim Mattson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhenyu Wang , Zhang Xiong , Like Xu , Jinrong Liang , Dapeng Mi Subject: Re: [kvm-unit-tests Patch v3 05/11] x86: pmu: Refine fixed_events[] names Message-ID: References: <20240103031409.2504051-1-dapeng1.mi@linux.intel.com> <20240103031409.2504051-6-dapeng1.mi@linux.intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103031409.2504051-6-dapeng1.mi@linux.intel.com> On Wed, Jan 03, 2024, Dapeng Mi wrote: > In SDM the fixed counter is numbered from 0 but currently the > fixed_events names are numbered from 1. It would cause confusion for > users. So Change the fixed_events[] names to number from 0 as well and > keep identical with SDM. > > Signed-off-by: Dapeng Mi Reviewed-by: Mingwei Zhang > --- > x86/pmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/x86/pmu.c b/x86/pmu.c > index 67ebfbe55b49..a2c64a1ce95b 100644 > --- a/x86/pmu.c > +++ b/x86/pmu.c > @@ -44,9 +44,9 @@ struct pmu_event { > {"branches", 0x00c2, 1*N, 1.1*N}, > {"branch misses", 0x00c3, 0, 0.1*N}, > }, fixed_events[] = { > - {"fixed 1", MSR_CORE_PERF_FIXED_CTR0, 10*N, 10.2*N}, > - {"fixed 2", MSR_CORE_PERF_FIXED_CTR0 + 1, 1*N, 30*N}, > - {"fixed 3", MSR_CORE_PERF_FIXED_CTR0 + 2, 0.1*N, 30*N} > + {"fixed 0", MSR_CORE_PERF_FIXED_CTR0, 10*N, 10.2*N}, > + {"fixed 1", MSR_CORE_PERF_FIXED_CTR0 + 1, 1*N, 30*N}, > + {"fixed 2", MSR_CORE_PERF_FIXED_CTR0 + 2, 0.1*N, 30*N} > }; > > char *buf; > -- > 2.34.1 >