Re: [PATCH v19 097/130] KVM: x86: Split core of hypercall emulation to helper function

Isaku Yamahata
2024-04-15T22:51:17Z

On Tue, Apr 09, 2024 at 05:28:05PM +0800,
Binbin Wu <binbin.wu@linux.intel.com> wrote:

> > +int kvm_emulate_hypercall(struct kvm_vcpu *vcpu)
> > +{
> > + unsigned long nr, a0, a1, a2, a3, ret;
> > + int op_64_bit;
>
> Can it be opportunistically changed to bool type, as well as the argument
> type of "op_64_bit" in __kvm_emulate_hypercall()?

Yes. We can also fix kvm_pv_send_ipi(op_64_bit).
--
Isaku Yamahata <isaku.yamahata@intel.com>