From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, Andrew Jones <andrew.jones@linux.dev>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] gitlab-ci: Fix the cirrus pipelines
Date: Mon, 15 Apr 2024 14:22:09 +0100 [thread overview]
Message-ID: <Zh0qAfYWGpORIGTl@redhat.com> (raw)
In-Reply-To: <20240415130321.149890-1-thuth@redhat.com>
On Mon, Apr 15, 2024 at 03:03:21PM +0200, Thomas Huth wrote:
> Pulling the "master" libvirt-ci containers does not work anymore,
> so we have to switch to the "latest" instead. See also:
We explicitly changed to publish under the 'latest' tag.
> https://gitlab.com/libvirt/libvirt/-/commit/5d591421220c850aa64a640
This commit is the root cause:
https://gitlab.com/libvirt/libvirt-ci/-/commit/6e3c5ccac77714be70c0dc52c5210c7cda8fe40f
The effects were dormant for a year as I didn't delete the old
':master' tags until two weeks ago.
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ff34b1f5..98177cdb 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -308,7 +308,7 @@ build-centos7:
> # https://gitlab.com/libvirt/libvirt/-/blob/v7.0.0/ci/README.rst
> #
> .cirrus_build_job_template: &cirrus_build_job_definition
> - image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
> + image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:latest
> before_script:
> - sed -e "s|[@]CI_REPOSITORY_URL@|$CI_REPOSITORY_URL|g"
> -e "s|[@]CI_COMMIT_REF_NAME@|$CI_COMMIT_REF_NAME|g"
> --
> 2.44.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-04-15 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 13:03 [kvm-unit-tests PATCH] gitlab-ci: Fix the cirrus pipelines Thomas Huth
2024-04-15 13:22 ` Daniel P. Berrangé [this message]
2024-04-15 13:44 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh0qAfYWGpORIGTl@redhat.com \
--to=berrange@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox