From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF74824BD for ; Mon, 15 Apr 2024 17:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713202180; cv=none; b=PHKMPWhCZUtxamsRevjqEKnd+vUrGxAGXeKEHGqiddRNSCtB+i9bIJnhQCvI1ilI6Jr9byKjfpjjWgMSI/aYX2zNhcgS1KZUtwLEo9/BbGQBWr1bVT8Zd1tUmaB5uIwqIB/gvClr7TfYA1ZUkYrrU+jwyfQrSaxVGSHwPcr3Om8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713202180; c=relaxed/simple; bh=PUtzAKK4XGFns+uyKdOsLt/oHxKeWqV+9+bXRP1a6Lk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c4Pw7G9SFLZvYqtvnUcYaFYxlnKu2n0ABS9cky6doozFBJ89azmSLuP8NU+NsJFMCa8KqOYNrP212VhEO1epAplDOeG65vK1oc73QWAJlnBJNr+Oa1npJoDLpWreU0jvsqSvLJXc0KvLId+YhfrzCJxwu+HzH4gAKEi/jQ197WI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JFzmbouA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JFzmbouA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713202178; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Jcg254LO2l1PxlFadfJBDxirLKjzh+T4Q2nk0YBiGYs=; b=JFzmbouAil25Gb8/jJfBY442NxUpEOFsIEJPzmNncBFHEKT8O/eYma8yD60p83dMalTay5 QmUQD0Hj8ei+QZf3aZYP1TrvIwkm2S8cjkXGgSkp9XAwsRyuSdhgLwRmCZkIjpYshJS00O J5ndomLfnfZEpsTOGAlsGwBe+uN30nk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-dCFN_PqVMxOwqdSj4GB4Ww-1; Mon, 15 Apr 2024 13:29:33 -0400 X-MC-Unique: dCFN_PqVMxOwqdSj4GB4Ww-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 55D5329AA394; Mon, 15 Apr 2024 17:29:32 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36E45C15771; Mon, 15 Apr 2024 17:29:31 +0000 (UTC) Date: Mon, 15 Apr 2024 18:29:25 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Shaoqin Huang Cc: qemu-arm@nongnu.org, Eric Auger , Peter Maydell , Paolo Bonzini , Thomas Huth , Laurent Vivier , qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20240409024940.180107-1-shahuang@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240409024940.180107-1-shahuang@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 On Mon, Apr 08, 2024 at 10:49:40PM -0400, Shaoqin Huang wrote: > The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide > which PMU events are provided to the guest. Add a new option > `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. > Without the filter, all PMU events are exposed from host to guest by > default. The usage of the new sub-option can be found from the updated > document (docs/system/arm/cpu-features.rst). > > Here is an example which shows how to use the PMU Event Filtering, when > we launch a guest by use kvm, add such command line: > > # qemu-system-aarch64 \ > -accel kvm \ > -cpu host,kvm-pmu-filter="D:0x11-0x11" I'm still against implementing this one-off custom parsed syntax for kvm-pmu-filter values. Once this syntax exists, we're locked into back-compatibility for multiple releases, and it will make a conversion to QAPI/JSON harder. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|