Re: [PATCH v2 14/14] virt: arm-cca-guest: TSM_REPORT support for realms

Suzuki K Poulose
2024-04-24T13:27:45Z

On 24/04/2024 14:06, Thomas Fossati wrote:
> Hi Steven, Sami,
>
> On Fri, 12 Apr 2024 at 10:47, Steven Price <steven.price@arm.com> wrote:
>> +/**
>> + * arm_cca_report_new - Generate a new attestation token.
>> + *
>> + * @report: pointer to the TSM report context information.
>> + * @data: pointer to the context specific data for this module.
>> + *
>> + * Initialise the attestation token generation using the challenge data
>> + * passed in the TSM decriptor.
>
> Here, it'd be good to document two interesting facts about challenge data:
> 1. It must be at least 32 bytes, and
> 2. If its size is less than 64 bytes, it will be zero-padded.

Agreed !

Suzuki

>
> cheers!