From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F2315ECD4 for ; Wed, 24 Apr 2024 14:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713970307; cv=none; b=VwnJueuuyo9pi49UuzT4W/NP44XUxZlJehfHWrXXxEs0N0TB6AgAD4xwdY+0hhL8dbR5kVmPSeSnz6f8iCDfYCUX9elN6wMqIyHCP8mxjdVPLtTy4ZIYJKWTHd2lCG7UlOMAAQMQS0Hk7Js36W7Kd43KKv4Oys2NPn2LkvJWK0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713970307; c=relaxed/simple; bh=L5PgwQXqh35ljEV/QfjmAhY+dATTVZXtCGt9GLB66PA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=T5/RTTS3lQYMyH2eICiIrGvF3ISEew9QUdtq1geZi+gGyCID8P9GPK4UqdK6/iB0VWaBz9ZYo+zm7TN1fHWsv4Wj8HHOoqljTV52/rlCgIT+7pyYiS29SGjeJFUAtXIiJdVCjAF7Y30u+nAAeFZAVxCk/F1iVPXwxEezdKtv6K8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=X78OGA4f; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="X78OGA4f" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2adf91ae2ddso1052a91.0 for ; Wed, 24 Apr 2024 07:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713970306; x=1714575106; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=CI1RTUkbvNrBSkw+K5Z39nzZbpfRzSvThM/4gtY5VFY=; b=X78OGA4fwe0/X+KjwaAwYyNgu+35YHb0vTrhK7LdBdREAUTNLhIidK7p4XiJuHKZ81 Qe/87ErcEWReDflfs7bIzsVt8t5zNZzeBfw4zdxhfh9YONQwgcD/95LmhAVah6txl0mi 36cPnqW0mIY3wfpor/TJA36iN1JfTlMEKwzLZK5Crw+cDWAwgHbElwzwtZnyOnfRHuvg RaQCcXFzJJ9d8yq2m6ctIQf0CRfonqe+1BAquEjLISrBJKbcIP6NnR26/6cROr4UHIm5 dj+Jf1P/mmlbKwOPEwO4t0tvn0q6NqL9AvZ3Yf1Zfrbl4/asZ5wi2wzaJ/e5Zkngj83/ nKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713970306; x=1714575106; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CI1RTUkbvNrBSkw+K5Z39nzZbpfRzSvThM/4gtY5VFY=; b=PleTPtxeIpRhXZZkVJXx1W30Wsxr2fYBi5BQCA3rNpIIBAlbbT7QDX9Up8Iyt5khOp lPkPUyrjA815NdTUWYOHRluhSQn22RdTVv6/X9KJSMqgQqesH/xx5S3xXrH7uK2rr4zv YHDz8NTUB7apZjY988KaFSh2C/mqc9HLs+OgOXvgC1D/dPmiOVtJdK3JNbkCwX2HZVSe wM6FfSaVwVGHpFbZRdliisRDBOTOlzkBc3dkupNtF+VbSf55uG+lBhH/U9ueYZfivi9S 5Dr5Ip6V84PZ5m0lzNEli2M/g+FMYOfLpXeBHIQ5RZt2EcvFtmG5zRz24iu1zxwcLfva 4kkA== X-Forwarded-Encrypted: i=1; AJvYcCV5MP3qVI/1SP+eSmCYzpVkn2kY6NjieVqLAxW0395sUfiiwvxfizQ9RmkpVpt9wgu7o4Fpey07WaW0Pz6aoTn3Rzg1 X-Gm-Message-State: AOJu0YzFllYfi1TVHRu1pnOdOKrrqeEFpRoyvZ8gJu0ahg0cpzWe+RuP fdEcK8+cl+CtN3/dPw5gjAok2zCFaNBlJtCqMAFe0pAzINptkm/nM1JDgnMGq0r/HTAMwOUs/am mrQ== X-Google-Smtp-Source: AGHT+IEkGEBGl103CCfB1x44lCEAhqJw73hICMcBVrYM5jo0ROCAmB4Ygu81wDS3jT7KCqkV6HSuf6vVHaE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:9f8d:b0:2ae:cb7e:b5b3 with SMTP id o13-20020a17090a9f8d00b002aecb7eb5b3mr10285pjp.6.1713970305856; Wed, 24 Apr 2024 07:51:45 -0700 (PDT) Date: Wed, 24 Apr 2024 07:51:44 -0700 In-Reply-To: <20240424-e31c64bda7872b0be52e4c16@orel> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240423073952.2001989-1-chentao@kylinos.cn> <878bf83c-cd5b-48d0-8b4e-77223f1806dc@web.de> <20240423-0db9024011213dcffe815c5c@orel> <20240424-e31c64bda7872b0be52e4c16@orel> Message-ID: Subject: Re: [PATCH] KVM: selftests: Add 'malloc' failure check in test_vmx_nested_state From: Sean Christopherson To: Andrew Jones Cc: Markus Elfring , Kunwu Chan , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org, Muhammad Usama Anjum , Paolo Bonzini , Shuah Khan , LKML , Kunwu Chan , Anup Patel , Thomas Huth , Oliver Upton Content-Type: text/plain; charset="us-ascii" On Wed, Apr 24, 2024, Andrew Jones wrote: > On Tue, Apr 23, 2024 at 12:15:47PM -0700, Sean Christopherson wrote: > ... > > I almost wonder if we should just pick a prefix that's less obviously connected > > to KVM and/or selftests, but unique and short. > > > > How about kvmsft_ ? It's based on the ksft_ prefix of kselftest.h. Maybe > it's too close to ksft though and would be confusing when using both in > the same test? I would prefer something short, and for whatever reason I have a mental block with ksft. I always read it as "k soft", which is completely nonsensical :-) > I'm not a huge fan of capital letters, but we could also do something like > MALLOC()/CALLOC(). Hmm, I'm not usually a fan either, but that could actually work quite well in this case. It would be quite intuitive, easy to visually parse whereas tmalloc() vs malloc() kinda looks like a typo, and would more clearly communicate that they're macros.