From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: "jmattson@google.com" <jmattson@google.com>,
Chao Gao <chao.gao@intel.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
Vishal Annapurve <vannapurve@google.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"mlevitsk@redhat.com" <mlevitsk@redhat.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable
Date: Wed, 24 Apr 2024 09:13:26 -0700 [thread overview]
Message-ID: <Ziku9m_1hQhJgm_m@google.com> (raw)
In-Reply-To: <6fae9b07de98d7f56b903031be4490490042ff90.camel@intel.com>
On Tue, Apr 16, 2024, Rick P Edgecombe wrote:
> On Thu, 2024-03-21 at 09:37 -0700, Reinette Chatre wrote:
> >
> > Summary
> > -------
> > Add KVM_CAP_X86_APIC_BUS_FREQUENCY capability to configure the APIC
> > bus clock frequency for APIC timer emulation.
> > Allow KVM_ENABLE_CAPABILITY(KVM_CAP_X86_APIC_BUS_FREQUENCY) to set the
> > frequency in nanoseconds. When using this capability, the user space
> > VMM should configure CPUID leaf 0x15 to advertise the frequency.
>
> Looks good to me and...
> Tested-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
> The only thing missing is actually integrating it into TDX qemu patches and
> testing the resulting TD. I think we are making a fair assumption that the
> problem should be resolved based on the analysis, but we have not actually
> tested that part. Is that right?
Please tell me that Rick is wrong, and that this actually has been tested with
a TDX guest. I don't care _who_ tested it, or with what VMM it has been tested,
but _someone_ needs to verify that this actually fixes the TDX issue.
next prev parent reply other threads:[~2024-04-24 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 16:37 [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable Reinette Chatre
2024-03-21 16:37 ` [PATCH V4 1/4] KVM: x86: hyper-v: Calculate APIC bus frequency for Hyper-V Reinette Chatre
2024-04-16 17:07 ` Edgecombe, Rick P
2024-03-21 16:37 ` [PATCH V4 2/4] KVM: x86: Make nsec per APIC bus cycle a VM variable Reinette Chatre
2024-04-16 17:08 ` Edgecombe, Rick P
2024-03-21 16:37 ` [PATCH V4 3/4] KVM: x86: Add a capability to configure bus frequency for APIC timer Reinette Chatre
2024-04-16 17:08 ` Edgecombe, Rick P
2024-04-16 21:28 ` Reinette Chatre
2024-04-17 3:37 ` Xiaoyao Li
2024-03-21 16:37 ` [PATCH V4 4/4] KVM: selftests: Add test for configure of x86 APIC bus frequency Reinette Chatre
2024-04-16 17:09 ` [PATCH V4 0/4] KVM: x86: Make bus clock frequency for vAPIC timer configurable Edgecombe, Rick P
2024-04-24 16:13 ` Sean Christopherson [this message]
2024-04-24 16:38 ` Edgecombe, Rick P
2024-04-24 17:23 ` Sean Christopherson
2024-04-24 18:10 ` Edgecombe, Rick P
2024-04-24 19:57 ` Sean Christopherson
2024-04-24 21:20 ` Reinette Chatre
2024-04-25 16:17 ` Sean Christopherson
2024-04-25 16:39 ` Reinette Chatre
2024-04-24 21:07 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ziku9m_1hQhJgm_m@google.com \
--to=seanjc@google.com \
--cc=chao.gao@intel.com \
--cc=erdemaktas@google.com \
--cc=isaku.yamahata@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=vannapurve@google.com \
--cc=vkuznets@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox