From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D34501BF47 for ; Tue, 16 Jul 2024 21:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721164071; cv=none; b=qaYqCKN1/1aCHxGeQvc3+HQhpi0d9pE1UVZL3dbnFMoTSuBjFa6QnkR38xS55sbwegBs1R2kP64csseaZp5Qh4cVNRNShkrqStqXeEjD1MA7Ru3rDfwi2Rpw7lMCm3Dq5K92Vh+BeGpZagyLsY5u99a4TGnUwrjpjfODZGRG590= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721164071; c=relaxed/simple; bh=xLwRgUEtiPeGNCRhFb5N/RLWBiXreg5PFnjrBVpkX2A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pBUqar5e9XfwHnhrQ05P3Gg8UC5raskFr9oge6jKTOw2G79dvZK5CDYgWuP82gURI5nOsyKWYRSpyvsVNJqmrGKere5hesihepEDypKAGcVk0jHzmb7NX14iDA9RjOTWNFDSWVA3f/w0/R/sGJKMa+i+lOpXRLEGGwzmjNG2tHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kfXvN+pW; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kfXvN+pW" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-70af58f79d1so4779424b3a.0 for ; Tue, 16 Jul 2024 14:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721164068; x=1721768868; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DNSo8wMNtEPJpK++67iaBSDns70oXM/KSOlCgrXK7Ls=; b=kfXvN+pWHTOTSPJ9vKnt+4qRZOjn0USYnd6msb0dp5dWQ4RsKk5/6wfrFPGUgbIfMS YM2hsKo+J/NdZL6mMg0YjaC1bs9zycqqXbssoDEbCfL3smIsbE6deLb4I5e0dNqTZphd R1NJAG6vJAe4JNpcp01puFMB6iE4w5yw/0SkK2Ypuses3T9dQ9vAHLsshqfPYVgnYN67 M1GYWfb5DIqgMiLHIrxklGMiqbDb+SnW56aIQlaHWdzYybUXHEs1/4bA/sfImciKbXbQ qtAN5O+G+xur7yJoEUmXtlqmXQGjbfHbxQgUOhbkxih3GIRF+6DLjN4GBcmQhZLLcHUg mTHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721164068; x=1721768868; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DNSo8wMNtEPJpK++67iaBSDns70oXM/KSOlCgrXK7Ls=; b=UaAte2OENCp+Q8/nhJHou5fY+ARfRNhF+SAJvbo+y3bbWTqlSI0frynkflKW5ull6k UQOlw2HQODpn5v9sqEbZdbLFYNtWOMbvCXRMHQmd6P+Uw3eYSeMibFc+JfvQFqWRuzl0 PdQscXwPpLRogzXBW0+srtZTXCbZFwTvRsllabGxiugluKODrwmdl43Es7yY+SYGoRvQ 2N52nMk9O0sFl5K3sDnK3Ki7n+1UiUMpNwSfixnvtFoRFEGpqh1vNIDi6aJ1uS1kKZ2J eav9fzNkcgX31uOLX6/RiSVW2l2quxoe9YYoTU9uUWJ0W/0qJ5VL/KOSqeG+Jcmy9Buo gjzg== X-Gm-Message-State: AOJu0Yxh2ufaUmG0r8y+qhV8yKuBd7OuJL9631ufVZ5UmnegDi1Pwy1h M8ssf/cW7EbK8V3T99IJ6sjuc0wQ2KTU046ap4dpSKxJ8C9+wRQte7U3bkMTyEWrB+hpahuNhLa Oig== X-Google-Smtp-Source: AGHT+IGLUH/Jz3hz7GJ232DTMeLmfXv2NQE7AIuBmDXbxZsUvaIwKAcy8kB9Zc33im3CkpfiA8pCvnHmHFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:1993:b0:706:5ca6:1c6b with SMTP id d2e1a72fcca58-70c1fb39f34mr252936b3a.1.1721164067842; Tue, 16 Jul 2024 14:07:47 -0700 (PDT) Date: Tue, 16 Jul 2024 14:07:46 -0700 In-Reply-To: <20240716022014.240960-2-mlevitsk@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240716022014.240960-1-mlevitsk@redhat.com> <20240716022014.240960-2-mlevitsk@redhat.com> Message-ID: Subject: Re: [PATCH v2 1/2] KVM: nVMX: use vmx_segment_cache_clear From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Paolo Bonzini , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Borislav Petkov , linux-kernel@vger.kernel.org, Dave Hansen , Thomas Gleixner Content-Type: text/plain; charset="us-ascii" On Mon, Jul 15, 2024, Maxim Levitsky wrote: > In prepare_vmcs02_rare, call vmx_segment_cache_clear, instead > of setting the segment_cache.bitmask directly. > > No functional change intended. > > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/vmx/nested.c | 5 +++-- > arch/x86/kvm/vmx/vmx.c | 4 ---- > arch/x86/kvm/vmx/vmx.h | 5 +++++ > 3 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > index 643935a0f70ab..d3ca1a772ae67 100644 > --- a/arch/x86/kvm/vmx/nested.c > +++ b/arch/x86/kvm/vmx/nested.c > @@ -2469,6 +2469,9 @@ static void prepare_vmcs02_rare(struct vcpu_vmx *vmx, struct vmcs12 *vmcs12) > > if (!hv_evmcs || !(hv_evmcs->hv_clean_fields & > HV_VMX_ENLIGHTENED_CLEAN_FIELD_GUEST_GRP2)) { > + > + vmx_segment_cache_clear(vmx); > + > vmcs_write16(GUEST_ES_SELECTOR, vmcs12->guest_es_selector); > vmcs_write16(GUEST_CS_SELECTOR, vmcs12->guest_cs_selector); > vmcs_write16(GUEST_SS_SELECTOR, vmcs12->guest_ss_selector); > @@ -2505,8 +2508,6 @@ static void prepare_vmcs02_rare(struct vcpu_vmx *vmx, struct vmcs12 *vmcs12) > vmcs_writel(GUEST_TR_BASE, vmcs12->guest_tr_base); > vmcs_writel(GUEST_GDTR_BASE, vmcs12->guest_gdtr_base); > vmcs_writel(GUEST_IDTR_BASE, vmcs12->guest_idtr_base); > - > - vmx->segment_cache.bitmask = 0; This actually exacerbates the bug that you're trying fix in patch 2. Clearing segment_cache.bitmask _after_ writing the relevant state limits the stale data to only the accessor that's running in IRQ context (kvm_arch_vcpu_put()). Clearing segment_cache.bitmask _before_ writing the relevant statement means that kvm_arch_vcpu_put() _and_ all future readers will be exposed to the stale data, because the stale data cached by kvm_arch_vcpu_put() won't mark it invalid.