From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D8A197A7A for ; Fri, 9 Aug 2024 15:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723218539; cv=none; b=rAyno8qat0JrR6bPgE0cLLPFrHBcVHKAu//rJFxsCFzIrsXaUQMKcVTd4UARTZsOdZhQg4IHrjo7l4YhpclG9ltD1Mc7dGQy3jqvSgxkl5/xjncitYW3EjeZt3oO88CT8PM2/SuGKtGzcz16ZZ87j9wEHEHMNdQ4p+H76ZVNm6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723218539; c=relaxed/simple; bh=boPHeK/FuzEsdNVjN9wdS1yaAPavvyaLNZ/AYT7mH0o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=aWQ7N9mC91O9Z+Ggp5p2RSjcuzfhV9uzjuF+qgACMYxzVsrh/1yjEbzlXA54Ktx4lWUbB4a4t/dvuGK/BqYZN7pdx8SM+H3oONGUlwxw+6M3pgDu50I0iFjIeMcVJu6KyIJF5ywJVHedgHwSeV1841NUCaIskXluW3fmEgOCENA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u5zGJCwD; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u5zGJCwD" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-778702b9f8fso1540715a12.1 for ; Fri, 09 Aug 2024 08:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723218536; x=1723823336; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EKWC05ur8qJ9dixBuWa+E5r9HRoDV0qFqOeFXTmXV1c=; b=u5zGJCwDvT+FJj+8DAncoZY9zVb+UKMn86t7ShWWYqU1EgSkmYV1bYhcodtu08K1BD WD/Ho4maoXtCa1pmOZHT1TN7vyy/4XB3yg4EZzbDDLDuFerahrHtyYgI116CZeCcIJSV w04Usxo+fZiWPLz2TbmxNDx244ywpAyTZ7PyuWT6ym12fIPQHyPqEOkHi1due54fBerV OE3CYM8UnprkBT0v3MIDY4mfSdZoldcQLMlFcOGh/TdbDfrIfNwXibAqc8RwlDUwSqQr IBhNUX9m+Pw0EbUx/fA/qMI0B3/ysqH1fubO0l/IdZX0CKVLco2iWHANDIFkDjLegrsw X18A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723218536; x=1723823336; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EKWC05ur8qJ9dixBuWa+E5r9HRoDV0qFqOeFXTmXV1c=; b=p8Vj5Uj9mmcNUa/J2DSCiaYUJ3yqEg7jAKEIxXkXRip3YldB7jpyD4kRJbv+fEijKX uIwxmUjBdqZ8Q3B/L0fPt0XEQfeCTd6daqPPTQnzRQSAoR/i8E6V0jn7bizQ262LTsv3 oCgKvJywga3yZ9gFHPpAXgAjwZ6DRMxHHyMOLLG0Cj4pshpfRrBQu70AfhGRapSJ+PP1 uRRNpZl1GNADxUJ+lM/+EMZ25UZihuwRTtLMCZI0PEMnCsWzma82PWrqbqZPGmffMkiU 2lkOsrp3VO+RemniOXiEcd5gnowgZ70ixqnIbTGvOZ3tEmIZ0WDnsNjHnnEtFkrOjeRY jCOw== X-Gm-Message-State: AOJu0Yyj1bwEFpUtnmf16Lo0VSg41aNIjDWmDGS00V68JUDZuzww2hsu j+To9dIDUYdhsdLwkjh7WMqh39ny51szi1JLi1Rm8E8BPN+TZFwiFo4IAyee3dp0BtyWJDS8HFa Xcw== X-Google-Smtp-Source: AGHT+IGcUTh0RPjHcAl9Gl6mOs8y4fOTciJ0KSSIq9N9x9qDCHR+caHcNrvhuZvHbeuXJhBlCaUN/9h7Hoc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a02:410d:b0:7a0:b292:47cb with SMTP id 41be03b00d2f7-7c3d2b997femr4904a12.0.1723218536385; Fri, 09 Aug 2024 08:48:56 -0700 (PDT) Date: Fri, 9 Aug 2024 08:48:55 -0700 In-Reply-To: <20240710220540.188239-5-pratikrajesh.sampat@amd.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240710220540.188239-1-pratikrajesh.sampat@amd.com> <20240710220540.188239-5-pratikrajesh.sampat@amd.com> Message-ID: Subject: Re: [RFC 4/5] selftests: KVM: SNP IOCTL test From: Sean Christopherson To: "Pratik R. Sampat" Cc: kvm@vger.kernel.org, shuah@kernel.org, thomas.lendacky@amd.com, michael.roth@amd.com, pbonzini@redhat.com, pgonda@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Wed, Jul 10, 2024, Pratik R. Sampat wrote: > Introduce testing of SNP ioctl calls. This patch includes both positive > and negative tests of various parameters such as flags, page types and > policies. > > Signed-off-by: Pratik R. Sampat > --- > .../selftests/kvm/x86_64/sev_smoke_test.c | 119 +++++++++++++++++- > 1 file changed, 118 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/sev_smoke_test.c b/tools/testing/selftests/kvm/x86_64/sev_smoke_test.c > index 500c67b3793b..1d5c275c11b3 100644 > --- a/tools/testing/selftests/kvm/x86_64/sev_smoke_test.c > +++ b/tools/testing/selftests/kvm/x86_64/sev_smoke_test.c > @@ -186,13 +186,130 @@ static void test_sev_launch(void *guest_code, uint32_t type, uint64_t policy) > kvm_vm_free(vm); > } > > +static int spawn_snp_launch_start(uint32_t type, uint64_t policy, uint8_t flags) > +{ > + struct kvm_vcpu *vcpu; > + struct kvm_vm *vm; > + int ret; > + > + vm = vm_sev_create_with_one_vcpu(type, NULL, &vcpu); Is a vCPU actually necessary/interesting? > + ret = snp_vm_launch(vm, policy, flags); > + kvm_vm_free(vm); > + > + return ret; > +} > + > +static void test_snp_launch_start(uint32_t type, uint64_t policy) > +{ > + uint8_t i; > + int ret; > + > + ret = spawn_snp_launch_start(type, policy, 0); s/spawn/__test, because "spawn" implies there's something living after this. > + TEST_ASSERT(!ret, > + "KVM_SEV_SNP_LAUNCH_START should not fail, invalid flag."); This should go away once vm_sev_ioctl() handles the assertion, but this assert message is bad (there's no invalid flag). > + > + for (i = 1; i < 8; i++) { > + ret = spawn_snp_launch_start(type, policy, BIT(i)); > + TEST_ASSERT(ret && errno == EINVAL, > + "KVM_SEV_SNP_LAUNCH_START should fail, invalid flag."); Print the flag, type, and policy. In general, please think about what information would be helpful if this fails.