Re: [PATCH 10/25] KVM: TDX: Initialize KVM supported capabilities when module setup

Paolo Bonzini
2024-09-10T16:58:13Z

On 8/30/24 10:34, Tony Lindgren wrote:
> On Tue, Aug 13, 2024 at 11:25:37AM +0800, Chao Gao wrote:
>> On Mon, Aug 12, 2024 at 03:48:05PM -0700, Rick Edgecombe wrote:
>>> From: Xiaoyao Li <xiaoyao.li@intel.com>
>>> +static int __init setup_kvm_tdx_caps(void)
>>> +{
>>> + const struct tdx_sysinfo_td_conf *td_conf = &tdx_sysinfo->td_conf;
>>> + u64 kvm_supported;
>>> + int i;
>>> +
>>> + kvm_tdx_caps = kzalloc(sizeof(*kvm_tdx_caps) +
>>> + sizeof(struct kvm_tdx_cpuid_config) * td_conf->num_cpuid_config,
>>
>> struct_size()
>>
>>> + GFP_KERNEL);
>>> + if (!kvm_tdx_caps)
>>> + return -ENOMEM;
>
> This will go away with the dropping of struct kvm_tdx_caps. Should be checked
> for other places though.

What do you mean exactly by dropping of struct kvm_tdx_caps?

Paolo