Re: [PATCH 10/25] KVM: TDX: Initialize KVM supported capabilities when module setup

Paolo Bonzini
2024-09-10T17:15:21Z

On 8/29/24 06:51, Tony Lindgren wrote:
>> nit: Since there are other similarly named functions that come later how
>> about rename this to init_kvm_tdx_caps, so that it's clear that the
>> functions that are executed ones are prefixed with "init_" and those that
>> will be executed on every TDV boot up can be named prefixed with "setup_"
> We can call setup_kvm_tdx_caps() from from tdx_get_kvm_supported_cpuid(),
> and drop the struct kvm_tdx_caps. So then the setup_kvm_tdx_caps() should
> be OK.

I don't understand this suggestion since tdx_get_capabilities() also
needs kvm_tdx_caps. I think the code is okay as it is with just the
rename that Nik suggested (there are already some setup_*() functions in
KVM but for example setup_vmcs_config() is called from hardware_setup()).

Paolo