From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A21C2AF1D for ; Wed, 9 Oct 2024 05:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728453302; cv=none; b=pXTF3aIvWl+WgTlmXKIad+upnxee/dq9hnzdgtW213TN73klFWkm/oStuyCJ4q+tmR4kVR2uOUMP3TYSHSZyTc6iUa4vQqksRCkzCYoCTiVRYx/XZPOJg+zQCyrhsknA57Ebpt6xknO8Q+tMosgJmiez6oFovGRvU6hbKypHfAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728453302; c=relaxed/simple; bh=wMTrGWrNqEJ/3vJS5OVwKl/YUiB1j9er0HSj6wg9YsY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HhT91FrtlZjhywNAenFsjoT6OSOIglTB99cDLS2XWpKKd6E6/vdT2nLHOzftCaXOgXbQTfJLCdJBHUav4nVRXMCIqJxkfjHNP/Y2Zqj9WAg6irQxE4wsSzg2hYylEQKWRg/N6M8rZFDiL1FNB/8d+fXYRw4akQpIKN+XYPKNO4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fhHb9x04; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fhHb9x04" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728453302; x=1759989302; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wMTrGWrNqEJ/3vJS5OVwKl/YUiB1j9er0HSj6wg9YsY=; b=fhHb9x04lTSHCCNlwte1jBBXg20KFLKUJzLG0lbaHhO3c87e+W1Qo5w+ I42UdvzKGv/ExtQybQ472le04ANivCv/kCyuzdgvxopkvtD509mMxVqcS vmxM2OddxoWSxcQv3eNQb4NJ3Apu4aXswd4uzqyo+JAuVYOx0Fz2ARNH6 QCI0DB0R8g5xk8NNMxugaRfzEazrX+6M8BpkwvDFVHIpSFwneWJ+zjHj1 4j/OQ5fVTf3GJ0MYu7VdjcNCHi5qww+XG5+/8/N/A0+Y/H2idL2V2sYrQ CT64VpD2git3613VBHVg1Sq8VzmiBZozyBY4h7x3bANhKdWFXQsV2T4uq g==; X-CSE-ConnectionGUID: GyqnaEk+ROCHrvmEp4bVPg== X-CSE-MsgGUID: UOY6xJMpQpe2hSuqvL4akw== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27623662" X-IronPort-AV: E=Sophos;i="6.11,189,1725346800"; d="scan'208";a="27623662" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 22:55:01 -0700 X-CSE-ConnectionGUID: tj+D1EMQTfGPh480WuhJkQ== X-CSE-MsgGUID: jqH4fZ4+RSaVVwxcKVhkAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,189,1725346800"; d="scan'208";a="81154308" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by orviesa004.jf.intel.com with ESMTP; 08 Oct 2024 22:54:55 -0700 Date: Wed, 9 Oct 2024 14:11:06 +0800 From: Zhao Liu To: Jonathan Cameron Cc: Daniel P =?utf-8?B?LiBCZXJyYW5n77+9?= , Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum , Philippe =?utf-8?B?TWF0aGlldS1EYXVk77+9?= , Yanan Wang , "Michael S . Tsirkin" , Paolo Bonzini , Richard Henderson , Sergio Lopez , Jason Wang , Stefano Stabellini , Anthony PERARD , Paul Durrant , "Edgar E . Iglesias" , Eric Blake , Markus Armbruster , Alex =?utf-8?B?QmVubu+/vWU=?= , Peter Maydell , qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-arm@nongnu.org, Zhenyu Wang , Dapeng Mi , Yongwei Ma , Zhao Liu Subject: Re: [RFC v2 03/12] system/vl: Create CPU topology devices from CLI early Message-ID: References: <20240919061128.769139-1-zhao1.liu@intel.com> <20240919061128.769139-4-zhao1.liu@intel.com> <20241008105545.000013e0@Huawei.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241008105545.000013e0@Huawei.com> On Tue, Oct 08, 2024 at 10:55:45AM +0100, Jonathan Cameron wrote: > Date: Tue, 8 Oct 2024 10:55:45 +0100 > From: Jonathan Cameron > Subject: Re: [RFC v2 03/12] system/vl: Create CPU topology devices from CLI > early > X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) > > > > + > > +static void qemu_add_cli_devices_early(void) > > +{ > > + long category = DEVICE_CATEGORY_CPU_DEF; > > + > > + qemu_add_devices(&category); > > +} > > + > > static void qemu_init_board(void) > > { > > /* process plugin before CPUs are created, but once -smp has been parsed */ > > @@ -2631,6 +2662,9 @@ static void qemu_init_board(void) > > /* From here on we enter MACHINE_PHASE_INITIALIZED. */ > > machine_run_board_init(current_machine, mem_path, &error_fatal); > > > > + /* Create CPU topology device if any. */ > > + qemu_add_cli_devices_early(); > I wonder if this is too generic a name? > > There are various other things we might want to do early. > Maybe qemu_add_cli_cpu_def() Sure, it makes sense.