From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F3B3214 for ; Thu, 17 Oct 2024 00:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729124597; cv=none; b=sRi2iP0wveN5JNihDolTMn4YkMfMjrtvUv4wbPJTPVvKECNxXwO8zSy13xlg2B7mi1qptHiBiU4udfXO1Y5Rcwky/8D1U5LjI9xLqZY1J9qAX8mdUkSGJVadtjiSZxe1UNhMN+JsgDqpthoNyV7u529ycCMHwWs9jIE+cJIyqJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729124597; c=relaxed/simple; bh=5bW49bD+EKSiVYlir+v4FtgYuuOeWvwSTqfDO39iuXY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tg5GwZacj+q+aloaG7TicRNP608fQQrfA9X2uj92q8q1pQsY5BLKKt8jJFPJh2TKKU+jXfIU1fRzXDsZTEezTMH/xazUGZGrnI7LoeTmLPOko6QCSu2cboAgnX5eZ7P5J0j0dRE/1MJ/vvF8azKxTPpIB71cz6e+lQRzKXnSzQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nuugg7X4; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nuugg7X4" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e291ac8dcf3so623825276.3 for ; Wed, 16 Oct 2024 17:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729124595; x=1729729395; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BDOAcCratkcKDtlnVKA6PegGNWwglEUHg+hVzvt764w=; b=nuugg7X4lPwH+k5zVajfCWMu8uCF91wMVQOSk6i8O5LF6i+eeGQo30Lp6XghoE86OB wIzLVJ6r0AVn0vZRjKM3iGZpWcacWfg0m0ZzaObM3ad1PGuUZyA5IPUzlA6QbTvdacS3 FzocCOoaZc37ytyz6YIbE9oKWUaTOI6u4wX6D3PsZFdhfiz0tI4iH2lew1fWveKT0kk7 r6aK6SJG6FNHojf7s1n4c9oMshvtxVE3opnYPoMBOt0qksT/H+/54HDZ8FybiBBTIDgm ZUbYMGcE2e47641jEZvhWyWFR+BgrRRtVPzbNP4ASnzaMBxffg8Q6jqtvgbyeqJ5Xydm TQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729124595; x=1729729395; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BDOAcCratkcKDtlnVKA6PegGNWwglEUHg+hVzvt764w=; b=dhuaFNxzNnzweN167HF+RF7pAcrZzKks1/gD1NHxMmc406WVW5erngmBzOc3c1PUVu UXjRyIEV8F803THdl1Sf2HaYBTwV5UbY0C6w56wifIJRV9zqC8XiZnhBfRzG2W/6bhFF 4yAgzVnvW4xyXx/Dh5l7pXKyJqs+G4VJCkpd9R7J71ppit97NSx/EVCASImhSY/Bo9BX Z/uEV0AvxacypcOe0EN14SE+UiE8GWfW9TRUioO9DfgR90xhyJmaMcDSzheHVcSz8ke7 dlPWxrRkecQgI/Gn3mWnjDL0H9GIeC9sgiKXKDV8bNTAT9B1NaEa+c0UcFWU6MKdKNz4 O2jg== X-Forwarded-Encrypted: i=1; AJvYcCU5ePnPaTvY12TDZQOXJfngjwTcaZC26dhF0NPwxvX0EnPfAOJGlqkJwTyHObYNbh+Uzq4=@vger.kernel.org X-Gm-Message-State: AOJu0YwOXalnB/mkHNybHXUZykxb38tXEWfK7TBdSa052hhPkqMCvsp3 Dn04YUdf3DXNI6dQgaHq6b/WNT5mWpp/nXuKORzchNLcuD0lHgO5fqdniNwzaCEZ48N4K9fIbui JKA== X-Google-Smtp-Source: AGHT+IE4l3MvTYNAOyrgYg8GdkVRXTmVWgsHaliM139NqF14S6D92z4C9+5nCmagCDbGXLX8HkyuisI1pSg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:aa6b:0:b0:e25:d46a:a6b6 with SMTP id 3f1490d57ef6-e297857f664mr5460276.8.1729124594453; Wed, 16 Oct 2024 17:23:14 -0700 (PDT) Date: Wed, 16 Oct 2024 17:23:13 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240926184546.833516-1-dwmw2@infradead.org> <20240926184546.833516-5-dwmw2@infradead.org> <408b137dbf60ff4d189cbd98b7cf8cd833579f61.camel@infradead.org> Message-ID: Subject: Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2 From: Sean Christopherson To: Oliver Upton Cc: David Woodhouse , Paolo Bonzini , Jonathan Corbet , Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Shuah Khan , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, Francesco Lavra , Miguel Luis Content-Type: text/plain; charset="us-ascii" On Tue, Oct 15, 2024, Oliver Upton wrote: > On Sat, Oct 12, 2024 at 10:28:10AM +0100, David Woodhouse wrote: > > I suspect the real answer here is that the individual tests here be > > calling ksft_test_result_pass(), and the system_off2 one should call > > ksft_test_result_skip() if it skips? > > modulo a few one-offs, KVM selftests doesn't use the kselftest harness > so it isn't subject to this comment. Since there's no test plan, we can > skip at any time. FWIW, I have some ideas on how to use the nicer pieces of kselftest harness, if anyone is looking for a project. :-) https://lore.kernel.org/all/ZjUwqEXPA5QVItyX@google.com