From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B721991DB for ; Mon, 21 Oct 2024 18:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729534393; cv=none; b=RuB6l4G35BAOaTp0kNUqD34aR+4MkU83cxt21CDDge2j7nIWg+um8uvqmDdE0kao4ZMW6JXg8L8t3dEFHSqNsqJEK4xGTFRn0VsYDyrE86fvXkRaPTrPZjSiAc8lalVBvCEBBA6hiTzYj6gCyiFl0Bj3N82mtLQ5MHxOT/4ludQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729534393; c=relaxed/simple; bh=YeXYNnt8ENmKuB15YwhakNFnDdgCdBZF4Bj1D5TS0z8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=AOxtC6k8Lxq+J2+agCgngG1FMLIavz6HUe8LZf1RbKtfPyLUAMaORg439OZHOz/Dy5RJU07Vd4NQN93dSqp5QFhtjQbXErnhuUCCQYTCrXQQ+uB2496ItHnsAgY2pQrtNqlOAgHi+u2KxnOygIbETyIqTlirt0vFPiZt1rvOies= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=euvnf9m6; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="euvnf9m6" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e290947f6f8so8215923276.2 for ; Mon, 21 Oct 2024 11:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729534390; x=1730139190; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=/aTJKIPGdXYIQ4z1/mPhLVqGYb++KmSjcoFUbuTd6EE=; b=euvnf9m6h38cfleq8wzhcd4+GPezfWhDdSBEJghp3op9X86av4HWg2QtcWhCtMBXNq XFKil0NVwBZRIO7Zy9h9NW/I+jNndbeC8nOEucR0KzKiO0KPk2JAMZL4kw/HS3gImzM1 7b1jSoBzFdWVAFnvs87kNBTtfAK8yFeuA5jkWJ2Qmop/DOj4nIxCIU+06f1szBnmxs4y h8Sgi1ltzAdT5jbwyIVOxnoxN8/TQb6D8duuHJuVoJV4Cy3ewh+7uks4GgMJ9dlkEQYI OFic8q7W0Ct8OQwCxk8ZVW2sUbg6POxpEGgxIzv9Sl+flZmIKpCzd1bOEz5mNoOBs+Bm lnQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729534390; x=1730139190; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/aTJKIPGdXYIQ4z1/mPhLVqGYb++KmSjcoFUbuTd6EE=; b=hd4Lf8BUNGWhe+yDKBu7Ueyrsfot6cx17EOfx4I7e6PnVWuE5uendGdn4sSBqk4+TK BI4hyxIuobErfjwGqzskuKjGOrIvLjlaSEPkKNn3f5LB8AqekEpQMxAfRJ1n97W5dUYs /S7CFfALzWzk1IZ1Pk+FszAZ+3BbPzimaQe565+vxxZp3ljQ8Eh7MWDLAUmsKAU3RGX3 J2sh9KEbEbGYzhCTd4f5Uo9rbQDq52ahVbdxlQWkvBJxb/Hd0sG3I6PywiU80bFgYG9A sKDduD2hTgFkEfO9kz89PVHi6OwTjxPJRS5Layq768oU2MUy27aPRVTp4DVYwz4DOqVx 44VA== X-Forwarded-Encrypted: i=1; AJvYcCVPta659yDlTuDzBllWEOHXn31IbFNc5dgYVkNhwB1bvahw2b1JzSox+PcwT6+WOv1sb/E=@vger.kernel.org X-Gm-Message-State: AOJu0YzWCft6f6mse3WfSpXcGgPOe/TCINGGTSkD/SLF1u8wZIf6B4Cc 0JXVLSChE+FHaqQSdsgWzrcNYc8cyYb28YMqpgezNsmRDawV/YZkQ9D0hj9bhVOtoZQPZlkouCW 0IQ== X-Google-Smtp-Source: AGHT+IGB051RPG0qZ1hHpRMmy9gqDX/0GH7so+xa+rGGnhbzxuPrj+6CH4debSRqPENvRC2d7Upq2p/funE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:8389:0:b0:e2b:e955:d58a with SMTP id 3f1490d57ef6-e2be955d949mr2592276.7.1729534389536; Mon, 21 Oct 2024 11:13:09 -0700 (PDT) Date: Mon, 21 Oct 2024 11:13:08 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241010182427.1434605-1-seanjc@google.com> <20241010182427.1434605-35-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 34/85] KVM: Get writable mapping for __kvm_vcpu_map() only when necessary From: Sean Christopherson To: Yan Zhao Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, "Alex =?utf-8?Q?Benn=C3=A9e?=" , David Matlack , David Stevens , Andrew Jones Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 21, 2024, Yan Zhao wrote: > On Thu, Oct 10, 2024 at 11:23:36AM -0700, Sean Christopherson wrote: > > When creating a memory map for read, don't request a writable pfn from = the > > primary MMU. While creating read-only mappings can be theoretically sl= ower, > > as they don't play nice with fast GUP due to the need to break CoW befo= re > > mapping the underlying PFN, practically speaking, creating a mapping is= n't > > a super hot path, and getting a writable mapping for reading is weird a= nd > > confusing. > >=20 > > Tested-by: Alex Benn=C3=A9e > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 080740f65061..b845e9252633 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -3122,7 +3122,7 @@ int __kvm_vcpu_map(struct kvm_vcpu *vcpu, gfn_t g= fn, struct kvm_host_map *map, > > struct kvm_follow_pfn kfp =3D { > > .slot =3D gfn_to_memslot(vcpu->kvm, gfn), > > .gfn =3D gfn, > > - .flags =3D FOLL_WRITE, > > + .flags =3D writable ? FOLL_WRITE : 0, > > .refcounted_page =3D &map->pinned_page, > > .pin =3D true, > > }; > When writable is false, could we set ".pin =3D false," ? Hmm, maybe? I can't imagine anything would actually break, but unless FOLL= _PIN implies writing, my preference would still be to pin the page so that KVM a= lways pins when accessing the actual data of a page. > Also not sure if ".map_writable =3D NULL" is missing. Doh, my previous response was slightly wrong, it's implicitly initialized t= o NULL, not false. I forgot map_writable is a pointer to a bool.