From: Sean Christopherson <seanjc@google.com>
To: Yong He <zhuangel570@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, wanpengli@tencent.com,
alexyonghe@tencent.com, junaids@google.com
Subject: Re: [PATCH 1/2] KVM: x86: expand the LRU cache of previous CR3s
Date: Tue, 29 Oct 2024 07:40:33 -0700 [thread overview]
Message-ID: <ZyDz4S0dYsRcBrTn@google.com> (raw)
In-Reply-To: <20241029031400.622854-2-alexyonghe@tencent.com>
KVM: x86/mmu:
On Tue, Oct 29, 2024, Yong He wrote:
> From: Yong He <alexyonghe@tencent.com>
>
> Expand max number of LRU cache of previous CR3s, so that
> we could cache more entry when needed, such as KPTI is
No "we". Documentation/process/maintainer-kvm-x86.rst
And I would argue this changelog is misleading. I was expecting that the patch
would actually change the number of roots that KVM caches, whereas this simply
increases the capacity. The changelog should also mention that the whole reason
for doing so is to allow for a module param.
Something like:
KVM: x86/mmu: Expand max capacity of per-MMU CR3/PGD caches
Expand the maximum capacity of the "previous roots" cache in kvm_mmu so
that a future patch can make the number of roots configurable via module
param, without needing to dynamically allocate the array.
That said, I hope we can avoid this entirely. More in the next patch.
next prev parent reply other threads:[~2024-10-29 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 3:13 [PATCH 0/2] Introduce configuration for LRU cache of previous CR3s Yong He
2024-10-29 3:13 ` [PATCH 1/2] KVM: x86: expand the " Yong He
2024-10-29 14:40 ` Sean Christopherson [this message]
2024-10-30 12:08 ` zhuangel570
2024-10-29 3:14 ` [PATCH 2/2] KVM: x86: introduce cache configurations for " Yong He
2024-10-29 15:14 ` Sean Christopherson
2024-10-30 12:51 ` zhuangel570
2024-11-06 1:42 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyDz4S0dYsRcBrTn@google.com \
--to=seanjc@google.com \
--cc=alexyonghe@tencent.com \
--cc=junaids@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wanpengli@tencent.com \
--cc=zhuangel570@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox