From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D11185B58 for ; Wed, 6 Nov 2024 15:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730905399; cv=none; b=MpKP1az3uhkOQeIAFp4DuCVSVXUnETmjWea+6Se9emz9wVr2+Bg16VdQjsoPSERAuQ39CHvbJLkRoce5gw4pkgX1a1JDxnTd6vtW8OlHoiNj3XWv475lxJ25SFhZ/3h79Nbmd91iKX64jn8prYJKDvqQycLkpTexFDdbgMwreqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730905399; c=relaxed/simple; bh=7mskR3JbIFxLTES60DnCyg1iGln2tKO42FQ/t4vQnxw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=YDO3i5KjnfvWZTRf4oNWbVLrfjNDZ53/D2mkDzqheVnhlqxJZ9OBodGjb4bVkYAS9BqsQn8YQucWFjpGZfb50rE+SJa+aB/fFOYp/rPktqxxJNUNCVDR2ZmwZRzMAcfblHhdvoYFXp/vNhGqkeWVE3qooF7c1Q/47tLpRWUr3B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Aq2Q79fz; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Aq2Q79fz" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-20e5ab8e022so73109405ad.3 for ; Wed, 06 Nov 2024 07:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730905396; x=1731510196; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hflnxKg+bZsrisTzBdaOMATh7WIEr10IKb+rd9v6h2M=; b=Aq2Q79fzuU8Hj1Gmn9pktO3+P5oP7LSDZ98M6vp2KakSRzvZqr1MUouHmOifY4vDUI wWgwusH4QsfaK6w0R5YBbg2zX5Ol8PJghnXYNOmbNk+cjIItCPGdFR4yjA7gRFsQNIRo 1JOL/6ZcWVDobVbPFjK1r7QTIg6PPVe/Mv8wCXgjZ9IrrIiFCCyuh8EH8SkNOpJ9btm7 4v6ninN4yqjSVgzwczi717U2TNoBVnnHm5ntuILpusWLwx/2rf5h5spivUEAi0l3Szr4 JDIA7rGlt5/3LxA5Ni1bApFe8lc/pTBejII1SPuOZN3+A6xD46kxM9ng5wbor/C1eryw T2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730905396; x=1731510196; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hflnxKg+bZsrisTzBdaOMATh7WIEr10IKb+rd9v6h2M=; b=lMwmMh23yQW4o/vHsbks+P1qDpgVI/AQVVDbcn26dImX7jI4D82o7cRkyAkslS5ARf n9ig1Gt1p5dPME8wcTbb8Hr8bp3Z5AZGARfm/kRiPj5EhYK3d11yGEPsnF97EFbyylbS caTsYJIrqB03viSfJXRV4bqMy1vh3aVv/yZP8wou+77DxdofxUjPV9D1rvR/icoDYHCk jp7QSNAequQ+NWb/CnLelvt3DC3vxuC0BsRZ4Q8SaBM2+v+toxEK/KskNjkt8AwHUYIF yZYq9KlL0aR86mCJRcOnMeQUzftR9IBZkfymk6hfkj9OthMHLDaOw2DWFowEAwIbZbtO tLPw== X-Forwarded-Encrypted: i=1; AJvYcCVKNt19X8l7xhYZXE2MU2R+l26IDx297loc7Di4cdkhJfO3SL7/RQ7yiJSFnqeEwJsOlF4=@vger.kernel.org X-Gm-Message-State: AOJu0YwIc97I6lYqY2WPBmLkEnjD4+iBU4sVUuLJjeIymh0BZxOMWOCT xM46HSDcQ+wcYeDFnqBkpnB4j6dyqjM/Hz8m/klhkLetZ/ow8cExSC3pNuhGM1ZCudBbTK9h9IY t/g== X-Google-Smtp-Source: AGHT+IHwIFs1+hd+w3m+efJcHtnNN4sJzJdSBWQ+cawiDwh+0SfyGDAKfXLwD0PDPV12ch/2yvmAAQbZ0Jw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:902:e810:b0:20e:5792:32ee with SMTP id d9443c01a7336-210c6d4e614mr6082805ad.10.1730905396372; Wed, 06 Nov 2024 07:03:16 -0800 (PST) Date: Wed, 6 Nov 2024 07:03:14 -0800 In-Reply-To: <20241105160234.1300702-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241105160234.1300702-1-superm1@kernel.org> Message-ID: Subject: Re: [PATCH] x86/CPU/AMD: Clear virtualized VMLOAD/VMSAVE on Zen4 client From: Sean Christopherson To: Mario Limonciello Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , Nikolay Borisov , Tom Lendacky , Brijesh Singh , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Mario Limonciello , kvm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" +KVM, given that this quite obviously affects KVM... On Tue, Nov 05, 2024, Mario Limonciello wrote: > From: Mario Limonciello > > A number of Zen4 client SoCs advertise the ability to use virtualized > VMLOAD/VMSAVE, but using these instructions is reported to be a cause > of a random host reboot. > > These instructions aren't intended to be advertised on Zen4 client > so clear the capability. > > Cc: stable@vger.kernel.org > Link: https://bugzilla.kernel.org/show_bug.cgi?id=219009 > Signed-off-by: Mario Limonciello > --- > arch/x86/kernel/cpu/amd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index 015971adadfc7..ecd42c2b3242e 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -924,6 +924,17 @@ static void init_amd_zen4(struct cpuinfo_x86 *c) > { > if (!cpu_has(c, X86_FEATURE_HYPERVISOR)) > msr_set_bit(MSR_ZEN4_BP_CFG, MSR_ZEN4_BP_CFG_SHARED_BTB_FIX_BIT); > + > + /* > + * These Zen4 SoCs advertise support for virtualized VMLOAD/VMSAVE > + * in some BIOS versions but they can lead to random host reboots. Uh, CPU bug? Erratum? > + */ > + switch (c->x86_model) { > + case 0x18 ... 0x1f: > + case 0x60 ... 0x7f: > + clear_cpu_cap(c, X86_FEATURE_V_VMSAVE_VMLOAD); > + break; > + } > } > > static void init_amd_zen5(struct cpuinfo_x86 *c) > -- > 2.43.0 >