From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [GIT PULL 1/2] KVM: s390: handle access registers in the run ioctl not in vcpu_put/load Date: Thu, 1 Dec 2016 13:28:43 +0100 Message-ID: References: <1480323998-210045-1-git-send-email-borntraeger@de.ibm.com> <1480323998-210045-2-git-send-email-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM , Cornelia Huck , Jens Freimann , linux-s390 To: Christian Borntraeger , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49396 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757155AbcLAM2q (ORCPT ); Thu, 1 Dec 2016 07:28:46 -0500 In-Reply-To: <1480323998-210045-2-git-send-email-borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 28.11.2016 um 10:06 schrieb Christian Borntraeger: > Right now we save the host access registers in kvm_arch_vcpu_load > and load them in kvm_arch_vcpu_put. Vice versa for the guest access > registers. On schedule this means, that we load/save access registers > multiple times. Wasn't the main point about this to also protect from scheduling another VCPU (maybe even from another VM)? (which in return would have its own set of access registers and therefore would now use the wrong set of access registers) Must likely I am forgetting something very important here :) -- David