From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D442D3225 for ; Thu, 18 Sep 2025 12:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758199198; cv=none; b=SCFQFqNrNOH+ZZqrVpVkBsWQc+NhmLkCASid2UctQCQ5Uaw3IDpoKq4QHyXeJ2uFFa8CM/6xIdihyMf5529hzZE3lEOL03CT685fb7RD0JErVkWevOk2TIQr6FDqyJOFti+L7+EIEAKx9cgZLCxKuUTfOeJtIJ27SGyw98gl+I8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758199198; c=relaxed/simple; bh=PHIbV5zebrrWibYezbhcv42KK++nOLaYp1fvIXUuL7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s8VRujeWE15IpRs5UU7IGV0+wAT6ZrU2mduMPx6Uh6oxv1s0oPeE6meJtcYHVyL+jH8sGgaMIQVQFGxEfFoli9u4sDagIDCU5Fbu7j1v9OpWIFGDSBT9qWmnIi844mWMXk5mJ/xCR037sibNnCvUz/o2y48jJ3pP4z8tnaHiVAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dLcD+0z8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dLcD+0z8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758199196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4iRNlJkDfeIewIlftz9psh7o4y2w3c47qbDM2qSNtnM=; b=dLcD+0z8CV1x7GX2ZFYNCTNnprkY7S4hfPX7isW7FaaEa2X+OnRpgfACRYrIbKAEFMOdul 2Q6kmzmKb2SM3UVdxdqqtRdfXGhyGWWhzVPGk0dx2xZ5gVknyGE33CQphV7xlsMvTMshoI gOyKUjLkEJgeGvrvTO9AoOT8VBygNhU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-IM0zPbKAPLuSFIINGayfEA-1; Thu, 18 Sep 2025 08:39:55 -0400 X-MC-Unique: IM0zPbKAPLuSFIINGayfEA-1 X-Mimecast-MFC-AGG-ID: IM0zPbKAPLuSFIINGayfEA_1758199194 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45f29eb22f8so4627295e9.0 for ; Thu, 18 Sep 2025 05:39:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758199194; x=1758803994; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4iRNlJkDfeIewIlftz9psh7o4y2w3c47qbDM2qSNtnM=; b=oN3u/un7kM8d3MIu3yGNtHgT2/qPTUxdtgrSLxYX9CeXSkfOV+tHSccKRdKAk4hwGf yuHf/+fnnrj31Go2EWYs5wUTTNyOJcz8LwdyyjjU4wYIEPmQMsrp/8sxnmotFNHTooqb 4rYiyQ2iSJJuXxioD9qF6vFTn3BYyHFb2XWdmfhH/nQh7dMirX2ShuSFU+0o20VFgC46 koGj/NWvcooLJDzF7/J518Pkya8g4FrWNmnuqkmqADinWl37Bx/UdUxhyhvOc0EYZD0o mN1b5NWAbeqTcPd5DgtQLqQA15x0AoPbDnAhW32oLZXAoBApvUIsdtynD3wdvnggYxeF PgTg== X-Forwarded-Encrypted: i=1; AJvYcCXiT1I/BDAYAcbU6mVLoJxuDAqZcjTpk07dKKGEXJst79wSJjadCqLwm5ZNuwCXnoPgOW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwZDfW6Rb4MlLOdK+ZLDejPLL144H9SIySkXbRarXG4EGTFydWV 1e2GJGHuryUPBneS6ywhxkKJMxJiqpVrgAEL2RG7bXCCfuor9iMNSDdfZL0RrR20SenfzFbr39l PDnAwBOeXgLN2UxpB0oETeQG+Ag+lf+8IijKn55op9ZNdZyMeRUDINg== X-Gm-Gg: ASbGnctohl94sgFPKN9saLOuVpT0eEWh5WR3BNhkBVraI3rb7Z4mkeNmVPxQcU7//1s qsM91M5M1XnE53ZkowmnPVG84NxuGMcBCueCQk/YhXpZI45c0Y1BnPetRUQn9MUVK8lotB8p8k4 cXlWLq43GTxWm7WUffgcfYhqKpuX9H1Sl4NOj2dOhv16lvQGkWId7yz51YxZjYDmnkv1RKLKubV N4cUrhRGgo90tVurpvotSuurt45HNU7lZkCrGFqh/UsV4TZsSHj7lQECpe3XIMw3c8rpddfmqIW 5m7Sehe/gLh/QjWmoHLjrbDqtJAdLgfWw+LE4wf5HMx15+2GJHjVOItHNedD36NzyWrHgJs3GHI VzQY= X-Received: by 2002:a05:600c:4692:b0:456:1824:4808 with SMTP id 5b1f17b1804b1-46206f04fa0mr49615065e9.32.1758199193626; Thu, 18 Sep 2025 05:39:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjjWetfU+UrVATF5g9s+b4IgVSgAwvY2uCYHs9l8/1t9RohQW+0YpN4S6uo5hwNFU4HgPR3g== X-Received: by 2002:a05:600c:4692:b0:456:1824:4808 with SMTP id 5b1f17b1804b1-46206f04fa0mr49614305e9.32.1758199193011; Thu, 18 Sep 2025 05:39:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f190721esm39108325e9.10.2025.09.18.05.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Sep 2025 05:39:52 -0700 (PDT) Message-ID: Date: Thu, 18 Sep 2025 14:39:49 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/35] memory: QOM-ify AddressSpace To: Akihiko Odaki , qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , Eric Auger , Helge Deller , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Aleksandar Rikalo , "Edgar E. Iglesias" , Alistair Francis , Ninad Palsule , Paolo Bonzini , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Jason Wang , Yi Liu , =?UTF-8?Q?Cl=C3=A9ment_Mathieu--Drif?= , Nicholas Piggin , Aditya Gupta , Gautam Menghani , Song Gao , Bibo Mao , Jiaxun Yang , Jonathan Cameron , Fan Ni , David Hildenbrand , Igor Mammedov , Xiao Guangrong , Beniamino Galvani , Strahinja Jankovic , Subbaraya Sundeep , Jan Kiszka , Laurent Vivier , Andrey Smirnov , Aurelien Jarno , BALATON Zoltan , Bernhard Beschow , Harsh Prateek Bora , Elena Ufimtseva , Jagannathan Raman , Palmer Dabbelt , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Matthew Rosato , Eric Farman , Thomas Huth , Halil Pasic , Christian Borntraeger , Ilya Leoshkevich , Fam Zheng , Bin Meng , Mark Cave-Ayland , Artyom Tarasenko , Peter Xu , Marcelo Tosatti , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, qemu-block@nongnu.org, kvm@vger.kernel.org, Alex Williamson , Stefano Garzarella , Alistair Francis References: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250917-qom-v1-0-7262db7b0a84@rsg.ci.i.u-tokyo.ac.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Akihiko, On 9/17/25 14:56, Akihiko Odaki wrote: > Based-on: <20250917-subregion-v1-0-bef37d9b4f73@rsg.ci.i.u-tokyo.ac.jp> > ("[PATCH 00/14] Fix memory region use-after-finalization") > > Make AddressSpaces QOM objects to ensure that they are destroyed when > their owners are finalized and also to get a unique path for debugging > output. > > Suggested by BALATON Zoltan: > https://lore.kernel.org/qemu-devel/cd21698f-db77-eb75-6966-d559fdcab835@eik.bme.hu/ > > Signed-off-by: Akihiko Odaki I wonder if this is going to fix an issue I was seeing a while ago in the FSI models. I couldn't find a clean way to avoid corrupting memory because of how the address_space was created and later on destroyed. See below, Thanks, C. from hw/fsi/ : typedef struct OPBus { BusState bus; MemoryRegion mr; AddressSpace as; } OPBus; typedef struct AspeedAPB2OPBState { ... OPBus opb[ASPEED_FSI_NUM]; ... } static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) { SysBusDevice *sbd = SYS_BUS_DEVICE(dev); AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); int i; /* * TODO: The OPBus model initializes the OPB address space in * the .instance_init handler and this is problematic for test * device-introspect-test. To avoid a memory corruption and a QEMU * crash, qbus_init() should be called from realize(). Something to * improve. Possibly, OPBus could also be removed. */ for (i = 0; i < ASPEED_FSI_NUM; i++) { qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s), NULL); } .... static void fsi_opb_init(Object *o) { OPBus *opb = OP_BUS(o); memory_region_init(&opb->mr, 0, TYPE_FSI_OPB, UINT32_MAX); address_space_init(&opb->as, &opb->mr, TYPE_FSI_OPB); }