From: Paolo Bonzini <pbonzini@redhat.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>, qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Boris Petkov <bp@suse.de>,
Tony Luck <tony.luck@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
rkrcmar@redhat.com, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v5 2/4] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg
Date: Wed, 22 Jun 2016 19:08:36 +0200 [thread overview]
Message-ID: <a19311e6-e2dd-7878-e4ae-bef893ed4426@redhat.com> (raw)
In-Reply-To: <20160622065624.25291-3-haozhong.zhang@intel.com>
On 22/06/2016 08:56, Haozhong Zhang wrote:
> +
> + val = g_malloc(sizeof(*val));
> + *val = feature_control_bits | FEATURE_CONTROL_LOCKED;
As noticed by Laszlo, you need to use cpu_to_le64 here. The maintainer
can fix it, I think.
Paolo
> + fw_cfg_add_file(pcms->fw_cfg, "etc/msr_feature_control", val, sizeof(*val));
> +}
next prev parent reply other threads:[~2016-06-22 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 6:56 [PATCH v5 0/4] Add QEMU support for Intel local MCE Haozhong Zhang
2016-06-22 6:56 ` [PATCH v5 1/4] target-i386: KVM: add basic Intel LMCE support Haozhong Zhang
2016-07-07 17:04 ` [Qemu-devel] " Eduardo Habkost
2016-06-22 6:56 ` [PATCH v5 2/4] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg Haozhong Zhang
2016-06-22 17:08 ` Paolo Bonzini [this message]
2016-06-23 6:08 ` Haozhong Zhang
2016-06-23 6:15 ` [RESEND PATCH " Haozhong Zhang
2016-07-07 17:06 ` [Qemu-devel] " Eduardo Habkost
2016-06-22 6:56 ` [PATCH v5 3/4] target-i386: enable LMCE for '-cpu host' if supported by host Haozhong Zhang
2016-07-07 17:05 ` [Qemu-devel] " Eduardo Habkost
2016-06-22 6:56 ` [PATCH v5 4/4] target-i386: abort migration if LMCE config mismatch Haozhong Zhang
2016-07-07 17:10 ` [Qemu-devel] " Eduardo Habkost
2016-07-08 2:41 ` Haozhong Zhang
2016-07-06 8:26 ` [Qemu-devel] [PATCH v5 0/4] Add QEMU support for Intel local MCE Laszlo Ersek
2016-07-06 8:35 ` Haozhong Zhang
2016-07-06 8:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19311e6-e2dd-7878-e4ae-bef893ed4426@redhat.com \
--to=pbonzini@redhat.com \
--cc=andi.kleen@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=rth@twiddle.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox