From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v5 2/4] i386: publish advised value of
 MSR_IA32_FEATURE_CONTROL via fw_cfg
Date: Wed, 22 Jun 2016 19:08:36 +0200
Message-ID: <a19311e6-e2dd-7878-e4ae-bef893ed4426@redhat.com>
References: <20160622065624.25291-1-haozhong.zhang@intel.com>
 <20160622065624.25291-3-haozhong.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	Boris Petkov <bp@suse.de>, Tony Luck <tony.luck@intel.com>,
	Andi Kleen <andi.kleen@intel.com>, rkrcmar@redhat.com,
	Ashok Raj <ashok.raj@intel.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>, qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36752 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751549AbcFVRIk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 22 Jun 2016 13:08:40 -0400
Received: by mail-wm0-f68.google.com with SMTP id c82so3165605wme.3
        for <kvm@vger.kernel.org>; Wed, 22 Jun 2016 10:08:39 -0700 (PDT)
In-Reply-To: <20160622065624.25291-3-haozhong.zhang@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 22/06/2016 08:56, Haozhong Zhang wrote:
> +
> +    val = g_malloc(sizeof(*val));
> +    *val = feature_control_bits | FEATURE_CONTROL_LOCKED;

As noticed by Laszlo, you need to use cpu_to_le64 here.  The maintainer
can fix it, I think.

Paolo

> +    fw_cfg_add_file(pcms->fw_cfg, "etc/msr_feature_control", val, sizeof(*val));
> +}