From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A091E832D for ; Sat, 8 Mar 2025 17:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741455589; cv=none; b=d/M4qQBBknlZG0EpRm6C8drCgxqthMgAHzM6KelKqhEV1jIkSZpoMTehfSIRjHdtMv/G8Q5uPJagqfbAChKUy5A52wBoYML/odlUJM7eKoy7OU3GexwTbpeP+dupf/NzDvVEcBZz5e44z6RvwjU9Ykg/CqRDd0OcbVLOgmnAo9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741455589; c=relaxed/simple; bh=J+SaCPFMc3bFF8JvDnCO33Se7yHilP5YS0DT2q9J+R0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IPAYZ8BVVUPVXv/8/3i08SnVjaCN8yxPTtaxrhoZuxxVxv7yPZVAY910zY3NCLPFcUkIBVx56FqsqKryOP0mJdq8yHY294xRuRWvBxnK9Ju+HNqA9cLEg2x91AjMxbBrHYzJC68z2ZlM/lLypHpa9Xdb5AzQ+r/5uG7ZIwRLKXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UU98VcOQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UU98VcOQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741455586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bGcfUxnZD2BDHLv4HPQl4B+PTJ6sdhEDZmj/JnVgQCA=; b=UU98VcOQg4KW7iYU2PP8A7jhn68SGDGei7ng7YU7u2MOKiVYxBGqirV5rybg11hYR4ghcB jbtmgESy+HBgN0Oe5ba96kg78kYVD66rhutsHrTD8D6AaYXzCD5EWgF09EdBXe6tE6XeLR v+cvzijm/ZT0H+xjp6jLKw0h9R5vDQQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-Ok1mW20CPuS32D6U7CrKEw-1; Sat, 08 Mar 2025 12:39:43 -0500 X-MC-Unique: Ok1mW20CPuS32D6U7CrKEw-1 X-Mimecast-MFC-AGG-ID: Ok1mW20CPuS32D6U7CrKEw_1741455582 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39123912ff0so1239416f8f.2 for ; Sat, 08 Mar 2025 09:39:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741455582; x=1742060382; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bGcfUxnZD2BDHLv4HPQl4B+PTJ6sdhEDZmj/JnVgQCA=; b=Ty7Te1Sb9TTG4Xb8WfGXhoX4wOPWuzyL1UMlL3oXhQqTaHrWNRyw+Q8Oa8eF/Dd4rU tRG/KA6i8c6URlagJX0/pZrIm0OBY908fAWQsOG/xv7w468VzYHKJ08QoCi0w4HXJ4XY kpDW7sWTwO+4t8GQ2lvclkRUloHh95uipvbM7OrvCTqkYkEmhFDpfX4lOf23VQPWiyXa uczt/f5TU4rvsm0rr4RWifCrQ+H9wxXuxK73HL7H712srR1DsVY8LM0g5pS0uCZWPCQ5 xQeboSKplgH27aMhHYiI5kS+/tvW3v2er2ZJ0Lgvdgzf/p71Iq0ZY1Cerv4ft+0d+Z4O qAYw== X-Forwarded-Encrypted: i=1; AJvYcCX6PeatSMdSkFLtMKQdlhPezRBW8OYztGxmokMcV13dR7vO1c0kKRESookJT14e5xroHTU=@vger.kernel.org X-Gm-Message-State: AOJu0YxJyPm8hCW1vbHepU7/fOHXTkQMQkYNeRNo8MjdmqetWd8nIUqv OeJzxXSzE5C5e+RK7oB9NrFW/N7HMEuy3S7p2dfG1bPavsu9UL32sRvsTaVKgpzECSm0siGT4qF Ac9Td9CxOj3SPupjA641AMq963ZMjlIRG7TEOLBGPx4ZMIKVF7w== X-Gm-Gg: ASbGncvlRrThW9jChlYcggUXKefbyljI7q3TlEad+EYzG0W641weq3ZFy4KQMcRnsS/ qBfNy2DdPuPgnljS0Z5QZSrgZZUksWc/6kS1xF91OwHtgZIAfqSMrX4YoiHdpNA0sdzxYxJ1Zbw gQ15mTsco9FRHGyIw9RNUuDWPyo5sHHBZJNtxTQ6vmR4R/D6CxpIcfbd1IBC+mGoMZauiP98f+A yYUK1NQsI+Bt+e+35GnNqPL5hILWyhWSkrr9vPlMfcRscqkea3mUeJQHUNe2pCTBG4/iNS6XBxS dEK5XsOQqGpYIoEUtxBXPmf8HGU9yaPRj1rZ79ZZKCPLvauLdJdM/A== X-Received: by 2002:a05:6000:1a87:b0:391:2391:2f79 with SMTP id ffacd0b85a97d-39132d98a8emr5549130f8f.43.1741455582241; Sat, 08 Mar 2025 09:39:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQMbpEoddj0se9YngZ5X8Iyjc8r63xl9sjZbhchD57b60ocj0gTwZgLixwwMk5jxxBRj8O/A== X-Received: by 2002:a05:6000:1a87:b0:391:2391:2f79 with SMTP id ffacd0b85a97d-39132d98a8emr5549097f8f.43.1741455581891; Sat, 08 Mar 2025 09:39:41 -0800 (PST) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c103aa5sm9499939f8f.94.2025.03.08.09.39.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Mar 2025 09:39:41 -0800 (PST) Message-ID: Date: Sat, 8 Mar 2025 18:39:40 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/14] hw/vfio: Compile some common objects once To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Alex Williamson , Igor Mammedov , qemu-ppc@nongnu.org, Thomas Huth , Richard Henderson , Tony Krowiak , Ilya Leoshkevich , kvm@vger.kernel.org, Yi Liu , Paolo Bonzini , Zhenzhong Duan , Matthew Rosato , Eric Farman , Peter Xu , Pierrick Bouvier , Daniel Henrique Barboza , Eric Auger , qemu-s390x@nongnu.org, Jason Herne , David Hildenbrand , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Harsh Prateek Bora , Nicholas Piggin , Halil Pasic , Christian Borntraeger References: <20250307180337.14811-1-philmd@linaro.org> <20250307180337.14811-4-philmd@linaro.org> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250307180337.14811-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/7/25 19:03, Philippe Mathieu-Daudé wrote: > Some files don't rely on any target-specific knowledge > and can be compiled once: > > - helpers.c > - container-base.c > - migration.c (removing unnecessary "exec/ram_addr.h") > - migration-multifd.c > - cpr.c > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/vfio/migration.c | 1 - > hw/vfio/meson.build | 13 ++++++++----- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c > index 416643ddd69..fbff46cfc35 100644 > --- a/hw/vfio/migration.c > +++ b/hw/vfio/migration.c > @@ -27,7 +27,6 @@ > #include "qapi/error.h" > #include "qapi/qapi-events-vfio.h" > #include "exec/ramlist.h" > -#include "exec/ram_addr.h" > #include "pci.h" > #include "trace.h" > #include "hw/hw.h" > diff --git a/hw/vfio/meson.build b/hw/vfio/meson.build > index 260d65febd6..8e376cfcbf8 100644 > --- a/hw/vfio/meson.build > +++ b/hw/vfio/meson.build > @@ -1,12 +1,7 @@ > vfio_ss = ss.source_set() > vfio_ss.add(files( > - 'helpers.c', > 'common.c', > - 'container-base.c', > 'container.c', > - 'migration.c', > - 'migration-multifd.c', > - 'cpr.c', > )) > vfio_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr.c')) > vfio_ss.add(when: 'CONFIG_IOMMUFD', if_true: files( > @@ -25,3 +20,11 @@ vfio_ss.add(when: 'CONFIG_VFIO_AP', if_true: files('ap.c')) > vfio_ss.add(when: 'CONFIG_VFIO_IGD', if_true: files('igd.c')) > > specific_ss.add_all(when: 'CONFIG_VFIO', if_true: vfio_ss) > + > +system_ss.add(when: 'CONFIG_VFIO', if_true: files( > + 'helpers.c', > + 'container-base.c', > + 'migration.c', > + 'migration-multifd.c', > + 'cpr.c', > +))