From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Gavin Shan <gshan@redhat.com>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, shuah@kernel.org, maz@kernel.org,
oliver.upton@linux.dev, shan.gavin@gmail.com
Subject: Re: [PATCH] KVM: selftests: Double check on the current CPU in rseq_test
Date: Thu, 14 Jul 2022 17:42:22 +0200 [thread overview]
Message-ID: <a2ade925-89db-5d05-ba44-e3b77125032e@redhat.com> (raw)
In-Reply-To: <YtA3s0VRj3x7vO7B@google.com>
On 7/14/22 17:35, Sean Christopherson wrote:
>> Can you check that smp_rmb() and smp_wmb() generate correct instructions on
>> arm64?
>
> That seems like the most likely scenario (or a kernel bug), I distinctly remember
> the barriers provided by tools/ being rather bizarre.
Maybe we should bite the bait and use C11 atomics in tools/. I've long
planned an article "C11 atomics for kernel programmers", especially
because this will also be an issue when Rust gets into the mix...
Paolo
next prev parent reply other threads:[~2022-07-14 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 8:06 [PATCH] KVM: selftests: Double check on the current CPU in rseq_test Gavin Shan
2022-07-14 13:52 ` Paolo Bonzini
2022-07-14 14:03 ` Paolo Bonzini
2022-07-14 15:35 ` Sean Christopherson
2022-07-14 15:42 ` Paolo Bonzini [this message]
2022-07-15 2:21 ` Gavin Shan
2022-07-15 14:32 ` Sean Christopherson
2022-07-16 14:46 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ade925-89db-5d05-ba44-e3b77125032e@redhat.com \
--to=pbonzini@redhat.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=seanjc@google.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox