From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/2] Lapic LDR fixup Date: Fri, 17 Nov 2017 21:27:34 +0100 Message-ID: References: <20171117115250.7564-1-dgilbert@redhat.com> <56843423-3d23-cb5a-d887-52597e02c241@redhat.com> <20171117193703.GE2421@work-vm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Dr. David Alan Gilbert" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161738AbdKQU1i (ORCPT ); Fri, 17 Nov 2017 15:27:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75CB2356F8 for ; Fri, 17 Nov 2017 20:27:37 +0000 (UTC) In-Reply-To: <20171117193703.GE2421@work-vm> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 17/11/2017 20:37, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonzini@redhat.com) wrote: >> On 17/11/2017 12:52, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> In x2apic mode the LDR should be fixed, however >>> it gets overwritten when the lapic state is loaded >>> after a migration. Change the fixup to keep LDR constant. >>> >>> Dave >>> >>> Dr. David Alan Gilbert (2): >>> KVM: lapic: Split out x2apic ldr calculation >>> KVM: lapic: Fixup LDR on load in x2apic >>> >>> arch/x86/kvm/lapic.c | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >> >> Queued, thanks. > > Hang on, there's something not right here. > I've got a Linux guest migration that's unstable with this > patch. > (Tasks blocked for >22seconds, generally memory related, so I'm > wondering if it's IPIs not happening) Too late, but I'll take a look as well on Monday, in case I can spot something obvious. Paolo