Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, kvm@vger.kernel.org
Cc: "Juan Quintela" <quintela@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 0/2] kvm: Some more trivial fixes for clear dirty log
Date: Wed, 8 May 2019 10:12:49 +0200	[thread overview]
Message-ID: <a440e3f0-384b-2173-2c55-6cb2641f7937@redhat.com> (raw)
In-Reply-To: <20190508054403.7277-1-peterx@redhat.com>

On 08/05/19 00:44, Peter Xu wrote:
> Two issues I've noticed when I'm drafting the QEMU support of it.
> With these two patches applied the QEMU binary (with the clear dirty
> log supported [1]) can migrate correctly otherwise the migration can
> stall forever if with/after heavy memory workload.
> 
> Please have a look, thanks.
> 
> [1] https://github.com/xzpeter/qemu/tree/kvm-clear-dirty-log
> 
> Peter Xu (2):
>   kvm: Fix the bitmap range to copy during clear dirty
>   kvm: Fix loop of clear dirty with off-by-one
> 
>  virt/kvm/kvm_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Looks good, but this is a blocker for using this feature in userspace.
I think we should change the capability name and number.

Paolo

  parent reply	other threads:[~2019-05-08  8:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08  5:44 [PATCH 0/2] kvm: Some more trivial fixes for clear dirty log Peter Xu
2019-05-08  5:44 ` [PATCH 1/2] kvm: Fix the bitmap range to copy during clear dirty Peter Xu
2019-05-08  5:44 ` [PATCH 2/2] kvm: Fix loop of clear dirty with off-by-one Peter Xu
2019-05-08  8:12 ` Paolo Bonzini [this message]
2019-05-08  8:36   ` [PATCH 0/2] kvm: Some more trivial fixes for clear dirty log Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a440e3f0-384b-2173-2c55-6cb2641f7937@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=quintela@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox