From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: nadav.amit@gmail.com, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 3/4] lib: Remove redeundant page zeroing
Date: Fri, 3 May 2019 12:57:40 -0700 [thread overview]
Message-ID: <a4e09bda-e8fb-9241-bbe9-3a307ca26c05@oracle.com> (raw)
In-Reply-To: <20190503103207.9021-4-nadav.amit@gmail.com>
On 05/03/2019 03:32 AM, nadav.amit@gmail.com wrote:
> From: Nadav Amit <nadav.amit@gmail.com>
>
> Now that alloc_page() zeros the page, remove the redundant page zeroing.
>
> Suggested-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> ---
> lib/virtio-mmio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/virtio-mmio.c b/lib/virtio-mmio.c
> index 57fe78e..e5e8f66 100644
> --- a/lib/virtio-mmio.c
> +++ b/lib/virtio-mmio.c
> @@ -56,7 +56,6 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev,
> vq = calloc(1, sizeof(*vq));
> assert(VIRTIO_MMIO_QUEUE_SIZE_MIN <= 2*PAGE_SIZE);
> queue = alloc_pages(1);
> - memset(queue, 0, 2*PAGE_SIZE);
> assert(vq && queue);
>
> writel(index, vm_dev->base + VIRTIO_MMIO_QUEUE_SEL);
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
next prev parent reply other threads:[~2019-05-03 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 10:32 [kvm-unit-tests PATCH v2 0/4] Zero allocated pages nadav.amit
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 1/4] lib/alloc_page: " nadav.amit
2019-05-03 19:10 ` Krish Sadhukhan
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 2/4] x86: Remove redeundant page zeroing nadav.amit
2019-05-03 19:11 ` Krish Sadhukhan
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 3/4] lib: " nadav.amit
2019-05-03 19:57 ` Krish Sadhukhan [this message]
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 4/4] arm: " nadav.amit
2019-05-09 8:59 ` Alexandru Elisei
2019-05-20 14:19 ` [kvm-unit-tests PATCH v2 0/4] Zero allocated pages Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e09bda-e8fb-9241-bbe9-3a307ca26c05@oracle.com \
--to=krish.sadhukhan@oracle.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox